winglang / wing

A programming language for the cloud ☁️ A unified programming model, combining infrastructure and runtime code into one language ⚡
https://winglang.io
Other
4.6k stars 180 forks source link

chore(sdk): add hint to secret.inflight value() methods #6385

Closed hasanaburayyan closed 2 weeks ago

hasanaburayyan commented 2 weeks ago

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

github-actions[bot] commented 2 weeks ago

Thanks for opening this pull request! :tada: Please consult the contributing guidelines for details on how to contribute to this project. If you need any assistence, don't hesitate to ping the relevant owner over Slack.

Topic Owner
Wing SDK and utility APIs @chriscbr
Wing Console @ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections @hasanaburayyan
Platforms and plugins @hasanaburayyan
Frontend resources (website, react, etc) @tsuf239
Language design @chriscbr
VSCode extension and language server @markmcculloh
Compiler architecture, inflights, lifting @yoav-steinberg
Wing Testing Framework @tsuf239
Wing CLI @markmcculloh
Build system, dev environment, releases @markmcculloh
Library Ecosystem @chriscbr
Documentation @hasanaburayyan
SDK test suite @tsuf239
Examples @hasanaburayyan
Wing Playground @eladcon
monadabot commented 2 weeks ago

Console preview environment is available at https://wing-console-pr-6385.fly.dev :rocket:

Last Updated (UTC) 2024-05-01 20:15
monadabot commented 2 weeks ago

Benchmarks

Comparison to Baseline 🟥⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜ | Benchmark | Before | After | Change | | :-- | --: | --: | --: | | version | 52ms±0.35 | 55ms±0.82 | +3ms (+5.58%)🟥 | | functions_1.test.w -t sim | 387ms±23.3 | 376ms±2.8 | -11ms (-2.73%)⬜ | | functions_1.test.w -t tf-aws | 768ms±8.15 | 771ms±7.79 | +2ms (+0.32%)⬜ | | jsii_big.test.w -t sim | 2620ms±21.22 | 2638ms±33.37 | +18ms (+0.67%)⬜ | | jsii_big.test.w -t tf-aws | 2798ms±10.8 | 2804ms±11.57 | +6ms (+0.2%)⬜ | | functions_10.test.w -t sim | 456ms±18.28 | 459ms±5.63 | +3ms (+0.71%)⬜ | | functions_10.test.w -t tf-aws | 1929ms±18.61 | 1895ms±13.24 | -34ms (-1.75%)⬜ | | jsii_small.test.w -t sim | 352ms±5.14 | 356ms±6.42 | +5ms (+1.36%)⬜ | | jsii_small.test.w -t tf-aws | 574ms±5.28 | 577ms±5.34 | +4ms (+0.62%)⬜ | | empty.test.w -t sim | 339ms±3.49 | 346ms±6.42 | +7ms (+2.21%)⬜ | | empty.test.w -t tf-aws | 553ms±6.12 | 568ms±10.97 | +15ms (+2.8%)⬜ | | hello_world.test.w -t sim | 372ms±3.22 | 373ms±5.31 | +1ms (+0.32%)⬜ | | hello_world.test.w -t tf-aws | 1445ms±21.1 | 1466ms±19.7 | +20ms (+1.41%)⬜ | ⬜ Within 1.5 standard deviations 🟩 Faster, Above 1.5 standard deviations 🟥 Slower, Above 1.5 standard deviations _Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI._
Results |name|mean|min|max|moe|sd| |----|----|----|----|----|----| |version|55ms|53ms|57ms|1ms|1ms| |functions_1.test.w -t sim|376ms|370ms|383ms|3ms|4ms| |functions_1.test.w -t tf-aws|771ms|754ms|787ms|8ms|11ms| |jsii_big.test.w -t sim|2638ms|2587ms|2719ms|33ms|47ms| |jsii_big.test.w -t tf-aws|2804ms|2778ms|2829ms|12ms|16ms| |functions_10.test.w -t sim|459ms|448ms|473ms|6ms|8ms| |functions_10.test.w -t tf-aws|1895ms|1864ms|1930ms|13ms|19ms| |jsii_small.test.w -t sim|356ms|341ms|368ms|6ms|9ms| |jsii_small.test.w -t tf-aws|577ms|568ms|589ms|5ms|7ms| |empty.test.w -t sim|346ms|328ms|357ms|6ms|9ms| |empty.test.w -t tf-aws|568ms|547ms|591ms|11ms|15ms| |hello_world.test.w -t sim|373ms|363ms|386ms|5ms|7ms| |hello_world.test.w -t tf-aws|1466ms|1415ms|1502ms|20ms|28ms|
Last Updated (UTC) 2024-05-01 20:20
mergify[bot] commented 2 weeks ago

Thanks for contributing, @hasanaburayyan! This PR will now be added to the merge queue, or immediately merged if hasan/enhance-secret-error is up-to-date with main and the queue is empty.

mergify[bot] commented 2 weeks ago

Thanks for contributing, @hasanaburayyan! This PR will now be added to the merge queue, or immediately merged if hasan/enhance-secret-error is up-to-date with main and the queue is empty.

monadabot commented 2 weeks ago

Congrats! :rocket: This was released in Wing 0.73.17.