winglang / wing

A programming language for the cloud ☁️ A unified programming model, combining infrastructure and runtime code into one language ⚡
https://winglang.io
Other
4.6k stars 180 forks source link

fix: inflight() features in @wingcloud/framework do not work #6402

Closed MarkMcCulloh closed 2 weeks ago

MarkMcCulloh commented 2 weeks ago

When the inflight() function was moved to the SDK, the special auto-import and extra validation provided by the ts framework stopped working. This PR makes the logic for detecting this special function slightly more rigorous by using jsdoc tags instead of relying on detecting the source module.

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

github-actions[bot] commented 2 weeks ago

Thanks for opening this pull request! :tada: Please consult the contributing guidelines for details on how to contribute to this project. If you need any assistence, don't hesitate to ping the relevant owner over Slack.

Topic Owner
Wing SDK and utility APIs @chriscbr
Wing Console @ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections @hasanaburayyan
Platforms and plugins @hasanaburayyan
Frontend resources (website, react, etc) @tsuf239
Language design @chriscbr
VSCode extension and language server @markmcculloh
Compiler architecture, inflights, lifting @yoav-steinberg
Wing Testing Framework @tsuf239
Wing CLI @markmcculloh
Build system, dev environment, releases @markmcculloh
Library Ecosystem @chriscbr
Documentation @hasanaburayyan
SDK test suite @tsuf239
Examples @hasanaburayyan
Wing Playground @eladcon
monadabot commented 2 weeks ago

Console preview environment is available at https://wing-console-pr-6402.fly.dev :rocket:

Last Updated (UTC) 2024-05-03 13:38
monadabot commented 2 weeks ago

Benchmarks

Comparison to Baseline ⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜🟥 | Benchmark | Before | After | Change | | :-- | --: | --: | --: | | version | 59ms±1.59 | 59ms±0.78 | 0ms (-0.29%)⬜ | | functions_1.test.w -t sim | 400ms±4.36 | 406ms±4.78 | +6ms (+1.56%)⬜ | | functions_1.test.w -t tf-aws | 828ms±3.31 | 834ms±11.49 | +6ms (+0.76%)⬜ | | jsii_big.test.w -t sim | 2818ms±14.77 | 2830ms±13.84 | +13ms (+0.45%)⬜ | | jsii_big.test.w -t tf-aws | 3030ms±11.66 | 3044ms±12.08 | +13ms (+0.44%)⬜ | | functions_10.test.w -t sim | 492ms±11.42 | 504ms±10.26 | +11ms (+2.28%)⬜ | | functions_10.test.w -t tf-aws | 2067ms±12.8 | 2068ms±10.93 | +1ms (+0.04%)⬜ | | jsii_small.test.w -t sim | 381ms±7.23 | 380ms±4.32 | -2ms (-0.4%)⬜ | | jsii_small.test.w -t tf-aws | 617ms±4.25 | 620ms±4.93 | +3ms (+0.48%)⬜ | | empty.test.w -t sim | 368ms±9.35 | 374ms±5.97 | +7ms (+1.84%)⬜ | | empty.test.w -t tf-aws | 601ms±4.3 | 603ms±8.7 | +2ms (+0.32%)⬜ | | hello_world.test.w -t sim | 399ms±3.12 | 407ms±5.91 | +8ms (+1.91%)⬜ | | hello_world.test.w -t tf-aws | 1534ms±6.24 | 1554ms±7.19 | +20ms (+1.32%)🟥 | ⬜ Within 1.5 standard deviations 🟩 Faster, Above 1.5 standard deviations 🟥 Slower, Above 1.5 standard deviations _Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI._
Results |name|mean|min|max|moe|sd| |----|----|----|----|----|----| |version|59ms|57ms|61ms|1ms|1ms| |functions_1.test.w -t sim|406ms|398ms|420ms|5ms|7ms| |functions_1.test.w -t tf-aws|834ms|823ms|878ms|11ms|16ms| |jsii_big.test.w -t sim|2830ms|2804ms|2857ms|14ms|19ms| |jsii_big.test.w -t tf-aws|3044ms|3024ms|3072ms|12ms|17ms| |functions_10.test.w -t sim|504ms|472ms|522ms|10ms|14ms| |functions_10.test.w -t tf-aws|2068ms|2044ms|2087ms|11ms|15ms| |jsii_small.test.w -t sim|380ms|369ms|388ms|4ms|6ms| |jsii_small.test.w -t tf-aws|620ms|610ms|628ms|5ms|7ms| |empty.test.w -t sim|374ms|359ms|389ms|6ms|8ms| |empty.test.w -t tf-aws|603ms|589ms|635ms|9ms|12ms| |hello_world.test.w -t sim|407ms|392ms|415ms|6ms|8ms| |hello_world.test.w -t tf-aws|1554ms|1542ms|1571ms|7ms|10ms|
Last Updated (UTC) 2024-05-03 13:43
mergify[bot] commented 2 weeks ago

Thanks for contributing, @MarkMcCulloh! This PR will now be added to the merge queue, or immediately merged if mark/fix-lifter-ts is up-to-date with main and the queue is empty.

monadabot commented 2 weeks ago

Congrats! :rocket: This was released in Wing 0.73.21.