winglang / wing

A programming language for the cloud ☁️ A unified programming model, combining infrastructure and runtime code into one language ⚡
https://winglang.io
Other
4.73k stars 185 forks source link

feat(sdk): add functions to expect module #6450

Closed srinumadhavv closed 1 month ago

srinumadhavv commented 1 month ago

Checklist

Evidences image image

NOTE : As Mentioned by @Chriscbr , this pr doesn't implement the following methods in issue #4785

contains()
doesNotContain()
throws()
doesNotThrow() 

are left until we have a proper support for typing

Once Merged this should close a part of #4785 for methods : ok, fail, match, doesNotMatch By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

github-actions[bot] commented 1 month ago

Thanks for opening this pull request! :tada: Please consult the contributing guidelines for details on how to contribute to this project. If you need any assistence, don't hesitate to ping the relevant owner over Slack.

Topic Owner
Wing SDK and utility APIs @chriscbr
Wing Console @ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections @hasanaburayyan
Platforms and plugins @hasanaburayyan
Frontend resources (website, react, etc) @tsuf239
Language design @chriscbr
VSCode extension and language server @markmcculloh
Compiler architecture, inflights, lifting @yoav-steinberg
Wing Testing Framework @tsuf239
Wing CLI @markmcculloh
Build system, dev environment, releases @markmcculloh
Library Ecosystem @chriscbr
Documentation @hasanaburayyan
SDK test suite @tsuf239
Examples @hasanaburayyan
Wing Playground @eladcon
tsuf239 commented 1 month ago

Can you please add a test written in Wing? similar to examples/tests/sdk_tests/expect/assert.test.w or in the same file Can you please add a link to the issue? (if you add "fixes #issue_number" it will be closed automatically when the PR is merged)

srinumadhavv commented 1 month ago

Can you please add a test written in Wing? similar to examples/tests/sdk_tests/expect/assert.test.w or in the same file Can you please add a link to the issue? (if you add "fixes #issue_number" it will be closed automatically when the PR is merged)

Hey @tsuf239 , where should i add this "fixes #issue_number" is it in the description of the pr or anywhere else ? and regd the test file i should add an example to each of the methods covered in this issue am i right ?

staycoolcall911 commented 1 month ago

Hey @tsuf239 , where should i add this "fixes #issue_number" is it in the description of the pr or anywhere else ? and regd the test file i should add an example to each of the methods covered in this issue am i right ?

Yes and yes

mergify[bot] commented 1 month ago

Thanks for contributing, @srinumadhavv! This PR will now be added to the merge queue, or immediately merged if main is up-to-date with main and the queue is empty.

monadabot commented 1 month ago

Congrats! :rocket: This was released in Wing 0.73.42.