winglang / wing

A programming language for the cloud ☁️ A unified programming model, combining infrastructure and runtime code into one language ⚡
https://winglang.io
Other
4.78k stars 189 forks source link

chore: ensure wingsdk compiles before running tests #6514

Closed MarkMcCulloh closed 1 month ago

MarkMcCulloh commented 1 month ago

Several parts of the SDK reference try to require/require.resolve @winglang/sdk/lib/... while inflight (e.g. for inflight clients). This directory only exists after the SDK has been compiled. This means the SDK tests depend on SDK itself being compiled first. This is unfortunate because we also compile parts of the SDK with tsc as the tests start up, and then vitest itself is also compiling/transpiling.

This PR is not doing anything to fix all that, but we at least need to ensure turbo is correctly modeling this dependency to avoid false test failures/successes.

As a side fix, I made eslint allow devDeps in test.config.mts to get rid of red squiggles in my IDE.

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

github-actions[bot] commented 1 month ago

Thanks for opening this pull request! :tada: Please consult the contributing guidelines for details on how to contribute to this project. If you need any assistance, don't hesitate to ping the relevant owner over Discord.

Topic Owner
Wing SDK and utility APIs @chriscbr
Wing Console @ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections @hasanaburayyan
Platforms and plugins @hasanaburayyan
Frontend resources (website, react, etc) @tsuf239
Language design @chriscbr
VSCode extension and language server @markmcculloh
Compiler architecture, inflights, lifting @yoav-steinberg
Wing Testing Framework @tsuf239
Wing CLI @markmcculloh
Build system, dev environment, releases @markmcculloh
Library Ecosystem @chriscbr
Documentation @hasanaburayyan
SDK test suite @tsuf239
Examples @hasanaburayyan
Wing Playground @eladcon
monadabot commented 1 month ago

Console preview environment is available at https://wing-console-pr-6514.fly.dev :rocket:

Last Updated (UTC) 2024-05-17 22:21
mergify[bot] commented 1 month ago

Thanks for contributing, @MarkMcCulloh! This PR will now be added to the merge queue, or immediately merged if mark/fix-bad-compilation is up-to-date with main and the queue is empty.

monadabot commented 1 month ago

Congrats! :rocket: This was released in Wing 0.73.55.