winglang / wing

A programming language for the cloud ☁️ A unified programming model, combining infrastructure and runtime code into one language ⚡
https://winglang.io
Other
4.77k stars 189 forks source link

fix(sdk): api path- collision with `/{proxy+}` #6543

Closed tsuf239 closed 1 month ago

tsuf239 commented 1 month ago

fixed:

5943

5210

tf-aws

image

aws-cdk

image

(the delete test passed in the next run- it was only failing because something in the env couldn't be destroyed)

image

and the cycle one doesn't work on main as well :)

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

github-actions[bot] commented 1 month ago

Thanks for opening this pull request! :tada: Please consult the contributing guidelines for details on how to contribute to this project. If you need any assistance, don't hesitate to ping the relevant owner over Discord.

Topic Owner
Wing SDK and utility APIs @chriscbr
Wing Console @ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections @hasanaburayyan
Platforms and plugins @hasanaburayyan
Frontend resources (website, react, etc) @tsuf239
Language design @chriscbr
VSCode extension and language server @markmcculloh
Compiler architecture, inflights, lifting @yoav-steinberg
Wing Testing Framework @tsuf239
Wing CLI @markmcculloh
Build system, dev environment, releases @markmcculloh
Library Ecosystem @chriscbr
Documentation @hasanaburayyan
SDK test suite @tsuf239
Examples @hasanaburayyan
Wing Playground @eladcon
monadabot commented 1 month ago

Console preview environment is available at https://wing-console-pr-6543.fly.dev :rocket:

Last Updated (UTC) 2024-05-26 12:06
tsuf239 commented 1 month ago

I noticed that the regex wasn't including the "/" path- so I fixed it and realized that we don't have an api test that includes only a root path "/"- so I changed the post.test.w to include one. it passes both in tf-aws and the sim

image
monadabot commented 1 month ago

Benchmarks

Comparison to Baseline 🟥⬜⬜⬜⬜⬜⬜⬜⬜🟥⬜⬜⬜ | Benchmark | Before | After | Change | | :-- | --: | --: | --: | | version | 58ms±0.55 | 60ms±0.63 | +2ms (+3.36%)🟥 | | functions_10.test.w -t sim | 502ms±16.97 | 502ms±15.61 | 0ms (-0.03%)⬜ | | functions_10.test.w -t tf-aws | 2093ms±15.89 | 2123ms±43.98 | +30ms (+1.44%)⬜ | | hello_world.test.w -t sim | 416ms±9.23 | 416ms±3.96 | +0ms (+0.04%)⬜ | | hello_world.test.w -t tf-aws | 1472ms±5.82 | 1479ms±9.44 | +6ms (+0.44%)⬜ | | functions_1.test.w -t sim | 416ms±7.65 | 413ms±4.68 | -3ms (-0.74%)⬜ | | functions_1.test.w -t tf-aws | 852ms±4.93 | 850ms±6.31 | -2ms (-0.22%)⬜ | | jsii_big.test.w -t sim | 2848ms±14.71 | 2860ms±16.72 | +12ms (+0.41%)⬜ | | jsii_big.test.w -t tf-aws | 3074ms±11.45 | 3074ms±10.73 | 0ms (-0.01%)⬜ | | empty.test.w -t sim | 367ms±4.82 | 381ms±3.31 | +14ms (+3.7%)🟥 | | empty.test.w -t tf-aws | 610ms±3.19 | 615ms±3.94 | +5ms (+0.77%)⬜ | | jsii_small.test.w -t sim | 383ms±4.19 | 388ms±4.34 | +5ms (+1.35%)⬜ | | jsii_small.test.w -t tf-aws | 628ms±3.82 | 628ms±5.83 | 0ms (-0.07%)⬜ | ⬜ Within 1.5 standard deviations 🟩 Faster, Above 1.5 standard deviations 🟥 Slower, Above 1.5 standard deviations _Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI._
Results |name|mean|min|max|moe|sd| |----|----|----|----|----|----| |version|60ms|59ms|61ms|1ms|1ms| |functions_10.test.w -t sim|502ms|450ms|527ms|16ms|22ms| |functions_10.test.w -t tf-aws|2123ms|2084ms|2294ms|44ms|61ms| |hello_world.test.w -t sim|416ms|404ms|422ms|4ms|6ms| |hello_world.test.w -t tf-aws|1479ms|1461ms|1500ms|9ms|13ms| |functions_1.test.w -t sim|413ms|404ms|422ms|5ms|7ms| |functions_1.test.w -t tf-aws|850ms|839ms|864ms|6ms|9ms| |jsii_big.test.w -t sim|2860ms|2820ms|2887ms|17ms|23ms| |jsii_big.test.w -t tf-aws|3074ms|3044ms|3094ms|11ms|15ms| |empty.test.w -t sim|381ms|373ms|389ms|3ms|5ms| |empty.test.w -t tf-aws|615ms|603ms|621ms|4ms|6ms| |jsii_small.test.w -t sim|388ms|375ms|393ms|4ms|6ms| |jsii_small.test.w -t tf-aws|628ms|612ms|640ms|6ms|8ms|
Last Updated (UTC) 2024-05-26 12:11
mergify[bot] commented 1 month ago

Thanks for contributing, @tsuf239! This PR will now be added to the merge queue, or immediately merged if tsuf/api-collusion-fix is up-to-date with main and the queue is empty.

monadabot commented 1 month ago

Congrats! :rocket: This was released in Wing 0.74.15.