IDE completion shows internal APIs

eladb commented 1 month ago

I tried this:

Dot complete a preflight object

This happened:

I expected this:

I think we should figure out a way to hide toString, onLift, and node from this list because they are internal APIs.

As an initial implementation maybe we can just add something like a @hidden doctag and hide them from the IDE completion list (I believe we will need to hard-code the addition of @hidden to constructs.Construct in the JSII importer because we can't modify the source).

Is there a workaround?

No response

Anything else?

No response

Wing Version

No response

Node.js Version

No response

Platform(s)

No response

Community Notes

Please vote by adding a 👍 reaction to the issue to help us prioritize.
If you are interested to work on this issue, please leave a comment.

MarkMcCulloh commented 1 month ago

What version of the CLI are you using? In the latest LSP rework (v0.74.17) members inherited from the constructs lib and from Resource should be hidden in completions.

eladb commented 1 month ago

Okay! Let me recheck

staycoolcall911 commented 3 weeks ago

@eladb - can we close this?

eladb commented 3 weeks ago

Yap looks good

winglang / wing