winglang / wing

A programming language for the cloud ☁️ A unified programming model, combining infrastructure and runtime code into one language ⚡
https://winglang.io
Other
4.76k stars 187 forks source link

feat(console): icon for custom resources #6588

Closed polamoros closed 1 month ago

polamoros commented 1 month ago

Resolves https://github.com/winglang/wing/issues/6587

github-actions[bot] commented 1 month ago

Thanks for opening this pull request! :tada: Please consult the contributing guidelines for details on how to contribute to this project. If you need any assistance, don't hesitate to ping the relevant owner over Discord.

Topic Owner
Wing SDK and utility APIs @chriscbr
Wing Console @ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections @hasanaburayyan
Platforms and plugins @hasanaburayyan
Frontend resources (website, react, etc) @tsuf239
Language design @chriscbr
VSCode extension and language server @markmcculloh
Compiler architecture, inflights, lifting @yoav-steinberg
Wing Testing Framework @tsuf239
Wing CLI @markmcculloh
Build system, dev environment, releases @markmcculloh
Library Ecosystem @chriscbr
Documentation @hasanaburayyan
SDK test suite @tsuf239
Examples @hasanaburayyan
Wing Playground @eladcon
monadabot commented 1 month ago

Console preview environment is available at https://wing-console-pr-6588.fly.dev :rocket:

Last Updated (UTC) 2024-05-29 12:58
monadabot commented 1 month ago

Benchmarks

Comparison to Baseline ⬜⬜⬜🟥⬜⬜⬜⬜⬜⬜⬜⬜⬜ | Benchmark | Before | After | Change | | :-- | --: | --: | --: | | version | 58ms±0.61 | 57ms±0.36 | -1ms (-2.04%)⬜ | | functions_10.test.w -t sim | 507ms±7.38 | 491ms±9.07 | -16ms (-3.1%)⬜ | | functions_10.test.w -t tf-aws | 2039ms±16.8 | 2054ms±18.9 | +15ms (+0.75%)⬜ | | hello_world.test.w -t sim | 399ms±7.37 | 417ms±10.6 | +18ms (+4.43%)🟥 | | hello_world.test.w -t tf-aws | 1455ms±8.15 | 1461ms±10.52 | +6ms (+0.42%)⬜ | | functions_1.test.w -t sim | 398ms±4.19 | 402ms±5.44 | +4ms (+1.07%)⬜ | | functions_1.test.w -t tf-aws | 817ms±7.33 | 835ms±6.07 | +18ms (+2.22%)⬜ | | jsii_big.test.w -t sim | 2825ms±20.07 | 2843ms±20.04 | +18ms (+0.63%)⬜ | | jsii_big.test.w -t tf-aws | 3033ms±14.32 | 3016ms±11.32 | -17ms (-0.55%)⬜ | | empty.test.w -t sim | 371ms±3.08 | 367ms±4.29 | -4ms (-1.12%)⬜ | | empty.test.w -t tf-aws | 591ms±6.93 | 595ms±5.42 | +4ms (+0.71%)⬜ | | jsii_small.test.w -t sim | 376ms±5.6 | 375ms±5.57 | -1ms (-0.34%)⬜ | | jsii_small.test.w -t tf-aws | 622ms±6.6 | 615ms±3.25 | -8ms (-1.22%)⬜ | ⬜ Within 1.5 standard deviations 🟩 Faster, Above 1.5 standard deviations 🟥 Slower, Above 1.5 standard deviations _Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI._
Results |name|mean|min|max|moe|sd| |----|----|----|----|----|----| |version|57ms|56ms|58ms|0ms|1ms| |functions_10.test.w -t sim|491ms|468ms|508ms|9ms|13ms| |functions_10.test.w -t tf-aws|2054ms|2024ms|2097ms|19ms|26ms| |hello_world.test.w -t sim|417ms|399ms|453ms|11ms|15ms| |hello_world.test.w -t tf-aws|1461ms|1437ms|1481ms|11ms|15ms| |functions_1.test.w -t sim|402ms|387ms|413ms|5ms|8ms| |functions_1.test.w -t tf-aws|835ms|823ms|853ms|6ms|8ms| |jsii_big.test.w -t sim|2843ms|2805ms|2902ms|20ms|28ms| |jsii_big.test.w -t tf-aws|3016ms|3001ms|3053ms|11ms|16ms| |empty.test.w -t sim|367ms|358ms|375ms|4ms|6ms| |empty.test.w -t tf-aws|595ms|584ms|606ms|5ms|8ms| |jsii_small.test.w -t sim|375ms|365ms|391ms|6ms|8ms| |jsii_small.test.w -t tf-aws|615ms|608ms|622ms|3ms|5ms|
Last Updated (UTC) 2024-05-29 11:28
ainvoner commented 1 month ago

@polamoros metadata icon doesn't change

Screenshot 2024-05-29 at 14 31 48

ainvoner commented 1 month ago

@polamoros also - connection icon

Screenshot 2024-05-29 at 14 33 16

polamoros commented 1 month ago

@polamoros also - connection icon

Screenshot 2024-05-29 at 14 33 16

fixed

image
mergify[bot] commented 1 month ago

Thanks for contributing, @polamoros! This PR will now be added to the merge queue, or immediately merged if 6587-console-icon-for-custom-resrouces is up-to-date with main and the queue is empty.

monadabot commented 1 month ago

Congrats! :rocket: This was released in Wing 0.74.23.