winglang / wing

A programming language for the cloud ☁️ A unified programming model, combining infrastructure and runtime code into one language ⚡
https://winglang.io
Other
4.75k stars 186 forks source link

feat: show connections for token references #6602

Closed eladb closed 2 weeks ago

eladb commented 3 weeks ago

Resolves #6433 by adding a connection edge when resources reference each other through tokens (e.g. a function references api.url). The fact that these are implicit references doesn't mean they are not references...

Console UI Tweaks

Misc

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

github-actions[bot] commented 3 weeks ago

Thanks for opening this pull request! :tada: Please consult the contributing guidelines for details on how to contribute to this project. If you need any assistance, don't hesitate to ping the relevant owner over Discord.

Topic Owner
Wing SDK and utility APIs @chriscbr
Wing Console @ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections @hasanaburayyan
Platforms and plugins @hasanaburayyan
Frontend resources (website, react, etc) @tsuf239
Language design @chriscbr
VSCode extension and language server @markmcculloh
Compiler architecture, inflights, lifting @yoav-steinberg
Wing Testing Framework @tsuf239
Wing CLI @markmcculloh
Build system, dev environment, releases @markmcculloh
Library Ecosystem @chriscbr
Documentation @hasanaburayyan
SDK test suite @tsuf239
Examples @hasanaburayyan
Wing Playground @eladcon
monadabot commented 3 weeks ago

Console preview environment is available at https://wing-console-pr-6602.fly.dev :rocket:

Last Updated (UTC) 2024-06-06 13:01
skyrpex commented 3 weeks ago

image

These kind of connections are visually awkward and confusing to me (from parent to child). That's why I suggested a few days ago to use pseudo-containers like these:

image

We keep a hint of the hierarchy but the connections are easier to read.

skyrpex commented 3 weeks ago

But that's subject for a different PR/proposal.

For now, maybe we could make it so the connections from parent to children go from west to east. I'll try amending the PR.

skyrpex commented 3 weeks ago

For now, maybe we could make it so the connections from parent to children go from west to east. I'll try amending the PR.

Nevermind, a proper refactor of the construct map nodes would be needed. It's a bit of a mess right now and can't easily do it.

mergify[bot] commented 2 weeks ago

Thanks for contributing, @eladb! This PR will now be added to the merge queue, or immediately merged if eladb/token-connections is up-to-date with main and the queue is empty.

monadabot commented 2 weeks ago

Congrats! :rocket: This was released in Wing 0.74.39.