Closed eladb closed 2 weeks ago
Thanks for opening this pull request! :tada: Please consult the contributing guidelines for details on how to contribute to this project. If you need any assistance, don't hesitate to ping the relevant owner over Discord.
Topic | Owner |
---|---|
Wing SDK and utility APIs | @chriscbr |
Wing Console | @ainvoner , @skyrpex , @polamoros |
JSON, structs, primitives and collections | @hasanaburayyan |
Platforms and plugins | @hasanaburayyan |
Frontend resources (website, react, etc) | @tsuf239 |
Language design | @chriscbr |
VSCode extension and language server | @markmcculloh |
Compiler architecture, inflights, lifting | @yoav-steinberg |
Wing Testing Framework | @tsuf239 |
Wing CLI | @markmcculloh |
Build system, dev environment, releases | @markmcculloh |
Library Ecosystem | @chriscbr |
Documentation | @hasanaburayyan |
SDK test suite | @tsuf239 |
Examples | @hasanaburayyan |
Wing Playground | @eladcon |
Console preview environment is available at https://wing-console-pr-6602.fly.dev :rocket:
These kind of connections are visually awkward and confusing to me (from parent to child). That's why I suggested a few days ago to use pseudo-containers like these:
We keep a hint of the hierarchy but the connections are easier to read.
But that's subject for a different PR/proposal.
For now, maybe we could make it so the connections from parent to children go from west to east. I'll try amending the PR.
For now, maybe we could make it so the connections from parent to children go from west to east. I'll try amending the PR.
Nevermind, a proper refactor of the construct map nodes would be needed. It's a bit of a mess right now and can't easily do it.
Thanks for contributing, @eladb! This PR will now be added to the merge queue, or immediately merged if eladb/token-connections
is up-to-date with main
and the queue is empty.
Congrats! :rocket: This was released in Wing 0.74.39.
Resolves #6433 by adding a connection edge when resources reference each other through tokens (e.g. a function references
api.url
). The fact that these are implicit references doesn't mean they are not references...Console UI Tweaks
()
from the connection operations because oftentimes they do not represent an actual method name. If we want to distinguish between operations and other types of connections, we should add this to the model and then display.sourceOp
in the connection. Do not default to the connection name.invokeAsync()
. Not sure why they were removed (resolves #6607)OnXxx
instead ofonxxx
(all lowercase).call
.Consumer
instead ofSetConsumer()
, alsoTick
(for schedules),Subscriber
(for topics).Misc
source
property ofnodeof(x).addConnection()
optional and default tothis
.Checklist
pr/e2e-full
label if this feature requires end-to-end testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.