winglang / wing

A programming language for the cloud ☁️ A unified programming model, combining infrastructure and runtime code into one language ⚡
https://winglang.io
Other
4.75k stars 186 forks source link

feat(console): implement resource running state indicators #6643

Closed skyrpex closed 1 day ago

skyrpex commented 2 weeks ago

Closes #6622.

github-actions[bot] commented 2 weeks ago

Thanks for opening this pull request! :tada: Please consult the contributing guidelines for details on how to contribute to this project. If you need any assistance, don't hesitate to ping the relevant owner over Discord.

Topic Owner
Wing SDK and utility APIs @chriscbr
Wing Console @ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections @hasanaburayyan
Platforms and plugins @hasanaburayyan
Frontend resources (website, react, etc) @tsuf239
Language design @chriscbr
VSCode extension and language server @markmcculloh
Compiler architecture, inflights, lifting @yoav-steinberg
Wing Testing Framework @tsuf239
Wing CLI @markmcculloh
Build system, dev environment, releases @markmcculloh
Library Ecosystem @chriscbr
Documentation @hasanaburayyan
SDK test suite @tsuf239
Examples @hasanaburayyan
Wing Playground @eladcon
monadabot commented 2 weeks ago

Console preview environment is available at https://wing-console-pr-6643.fly.dev :rocket:

Last Updated (UTC) 2024-06-19 10:35
monadabot commented 2 weeks ago

Benchmarks

Comparison to Baseline 🟥⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜ | Benchmark | Before | After | Change | | :-- | --: | --: | --: | | version | 56ms±0.69 | 57ms±0.66 | +2ms (+3.18%)🟥 | | functions_10.test.w -t sim | 522ms±19.35 | 498ms±9.65 | -24ms (-4.58%)⬜ | | functions_10.test.w -t tf-aws | 2082ms±19.83 | 2118ms±23.75 | +36ms (+1.72%)⬜ | | hello_world.test.w -t sim | 400ms±4.01 | 400ms±3.83 | +1ms (+0.14%)⬜ | | hello_world.test.w -t tf-aws | 1448ms±8.74 | 1459ms±5.22 | +11ms (+0.78%)⬜ | | functions_1.test.w -t sim | 399ms±6.71 | 401ms±5.71 | +2ms (+0.62%)⬜ | | functions_1.test.w -t tf-aws | 829ms±11.11 | 831ms±8.69 | +2ms (+0.19%)⬜ | | jsii_big.test.w -t sim | 2793ms±10.38 | 2798ms±14.48 | +5ms (+0.2%)⬜ | | jsii_big.test.w -t tf-aws | 2996ms±17.69 | 2994ms±6.47 | -2ms (-0.05%)⬜ | | empty.test.w -t sim | 365ms±8.7 | 363ms±5.25 | -2ms (-0.66%)⬜ | | empty.test.w -t tf-aws | 592ms±3.49 | 594ms±3.93 | +2ms (+0.36%)⬜ | | jsii_small.test.w -t sim | 373ms±4.5 | 375ms±4.19 | +2ms (+0.45%)⬜ | | jsii_small.test.w -t tf-aws | 609ms±4.88 | 607ms±5.25 | -3ms (-0.42%)⬜ | ⬜ Within 1.5 standard deviations 🟩 Faster, Above 1.5 standard deviations 🟥 Slower, Above 1.5 standard deviations _Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI._
Results |name|mean|min|max|moe|sd| |----|----|----|----|----|----| |version|57ms|56ms|59ms|1ms|1ms| |functions_10.test.w -t sim|498ms|467ms|512ms|10ms|13ms| |functions_10.test.w -t tf-aws|2118ms|2070ms|2192ms|24ms|33ms| |hello_world.test.w -t sim|400ms|394ms|412ms|4ms|5ms| |hello_world.test.w -t tf-aws|1459ms|1444ms|1467ms|5ms|7ms| |functions_1.test.w -t sim|401ms|391ms|419ms|6ms|8ms| |functions_1.test.w -t tf-aws|831ms|814ms|855ms|9ms|12ms| |jsii_big.test.w -t sim|2798ms|2769ms|2840ms|14ms|20ms| |jsii_big.test.w -t tf-aws|2994ms|2981ms|3012ms|6ms|9ms| |empty.test.w -t sim|363ms|350ms|372ms|5ms|7ms| |empty.test.w -t tf-aws|594ms|585ms|603ms|4ms|6ms| |jsii_small.test.w -t sim|375ms|365ms|381ms|4ms|6ms| |jsii_small.test.w -t tf-aws|607ms|590ms|617ms|5ms|7ms|
Last Updated (UTC) 2024-06-14 10:32
skyrpex commented 2 weeks ago

localhost_5173_ (13) localhost_5173_ (12) localhost_5173_ (11) localhost_5173_ (10) localhost_5173_ (9)

skyrpex commented 2 weeks ago

I think I'm also going to bubble upwards loading statuses (e.g. a child is loading, so the parent will show loading as well).

eladb commented 1 week ago

image

In the side panel, instead of the red dot, can we add another "Label" called "Status" with a text status and a red dot?

skyrpex commented 1 week ago

@eladb something like this?

image

eladb commented 1 week ago

@eladb something like this?

image

Yes! And it should be easy to click on this and see the errors (e.g. through the log filter when it will be implemented).

eladb commented 1 week ago

@skyrpex can you share a screen recording of how this looks with the "loading" animation? I don't see this in the preview environment.

skyrpex commented 1 week ago

@skyrpex can you share a screen recording of how this looks with the "loading" animation? I don't see this in the preview environment.

https://github.com/winglang/wing/assets/1077520/fcce1c97-20b0-4597-859a-1c900ed22ebe

mergify[bot] commented 1 day ago

Thanks for contributing, @skyrpex! This PR will now be added to the merge queue, or immediately merged if implement-resource-running-state-indicators is up-to-date with main and the queue is empty.

monadabot commented 1 day ago

Congrats! :rocket: This was released in Wing 0.75.8.