feat(console): filter logs by a specific resource andor resource type

winglang / wing

A programming language for the cloud ☁️ A unified programming model, combining infrastructure and runtime code into one language ⚡

https://winglang.io

Other

4.76k stars 187 forks source link

feat(console): filter logs by a specific resource andor resource type #6685

Closed polamoros closed 2 weeks ago

polamoros commented 2 weeks ago

Resolves https://github.com/winglang/wing/issues/1413

This PR adds:

Filter logs by Resource Type
Filter logs by resource Id
Button to clear filters
Banner showing the number of filtered logs

github-actions[bot] commented 2 weeks ago

Thanks for opening this pull request! :tada: Please consult the contributing guidelines for details on how to contribute to this project. If you need any assistance, don't hesitate to ping the relevant owner over Discord.

Topic	Owner
Wing SDK and utility APIs	`@chriscbr`
Wing Console	`@ainvoner`, `@skyrpex`, `@polamoros`
JSON, structs, primitives and collections	`@hasanaburayyan`
Platforms and plugins	`@hasanaburayyan`
Frontend resources (website, react, etc)	`@tsuf239`
Language design	`@chriscbr`
VSCode extension and language server	`@markmcculloh`
Compiler architecture, inflights, lifting	`@yoav-steinberg`
Wing Testing Framework	`@tsuf239`
Wing CLI	`@markmcculloh`
Build system, dev environment, releases	`@markmcculloh`
Library Ecosystem	`@chriscbr`
Documentation	`@hasanaburayyan`
SDK test suite	`@tsuf239`
Examples	`@hasanaburayyan`
Wing Playground	`@eladcon`

monadabot commented 2 weeks ago

Console preview environment is available at https://wing-console-pr-6685.fly.dev :rocket:

Last Updated (UTC) 2024-06-14 07:52

polamoros commented 2 weeks ago

This is how it looks!

thoughts?

ainvoner commented 2 weeks ago

Screenshot 2024-06-13 at 10 31 32

@polamoros I think that when there are logs, but all of them are filtered - we shouldn't display "No logs"

skyrpex commented 2 weeks ago

The contrast between the icon and the labels feel odd:

This is from the tree:

I'd tone down the icon color.

polamoros commented 2 weeks ago

The contrast between the icon and the labels feel odd:

This is from the tree:

I'd tone down the icon color.

@skyrpex done! 👍

skyrpex commented 2 weeks ago

One more request: when using search and having no results, change the labels to No resources found for the given query and No types found for the given query.

skyrpex commented 2 weeks ago

The All types / resources option shouldn't be searchable IMO, it should always be present 🤔

mergify[bot] commented 2 weeks ago

Thanks for contributing, @polamoros! This PR will now be added to the merge queue, or immediately merged if 1413-filter-logs-by-a-specific-resource-andor-resource-type is up-to-date with main and the queue is empty.

monadabot commented 2 weeks ago

Congrats! :rocket: This was released in Wing 0.74.59.