fix(sdk): cloud deployment fails if root directory contains spaces

tsuf239 commented 1 month ago

fixes: #6465

terraformAsset can't handle file paths that contain spaces- so I created the bundle zip manually- ONLY if there's a spaced path- since it hurts the benchmarks a bit

Checklist

[ ] Title matches Winglang's style guide
[ ] Description explains motivation and solution
[ ] Tests added (always)
[ ] Docs updated (only required for features)
[ ] Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

github-actions[bot] commented 1 month ago

Thanks for opening this pull request! :tada: Please consult the contributing guidelines for details on how to contribute to this project. If you need any assistance, don't hesitate to ping the relevant owner over Discord.

Topic	Owner
Wing SDK and standard library	`@chriscbr`
Wing Console	`@skyrpex`
Wing compiler and language design	`@chriscbr`
VSCode extension and language server	`@chriscbr`
Wing CLI	`@chriscbr`
Documentation	`@boyney123`
Examples	`@boyney123`
Wing Playground	`@skyrpex`

monadabot commented 1 month ago

Console preview environment is available at https://wing-console-pr-7188.fly.dev :rocket:

Last Updated (UTC) 2024-10-08 20:12

monadabot commented 1 month ago

Benchmarks

Comparison to Baseline ⬜⬜⬜⬜⬜⬜⬜⬜⬜🟥🟥🟥⬜

| Benchmark | Before | After | Change | | :-- | --: | --: | --: | | version | 59ms±1.13 | 56ms±0.35 | -3ms (-4.94%)⬜ | | hello_world.test.w -t sim | 421ms±4.02 | 417ms±11.35 | -4ms (-0.95%)⬜ | | hello_world.test.w -t tf-aws | 1559ms±19.75 | 1519ms±7.12 | -40ms (-2.59%)⬜ | | jsii_small.test.w -t sim | 391ms±4.21 | 385ms±4.76 | -5ms (-1.35%)⬜ | | jsii_small.test.w -t tf-aws | 643ms±4.59 | 619ms±13.74 | -24ms (-3.78%)⬜ | | jsii_big.test.w -t sim | 3025ms±12.52 | 3025ms±22.32 | 0ms (-0.01%)⬜ | | jsii_big.test.w -t tf-aws | 3240ms±19.76 | 3229ms±19.15 | -11ms (-0.34%)⬜ | | empty.test.w -t sim | 378ms±6.38 | 379ms±4.47 | +1ms (+0.33%)⬜ | | empty.test.w -t tf-aws | 626ms±5.56 | 617ms±6.71 | -10ms (-1.53%)⬜ | | functions_10.test.w -t sim | 493ms±22.63 | 521ms±7.87 | +28ms (+5.61%)🟥 | | functions_10.test.w -t tf-aws | 2194ms±27.27 | 2278ms±11.76 | +84ms (+3.83%)🟥 | | functions_1.test.w -t sim | 410ms±3.7 | 423ms±3.97 | +13ms (+3.12%)🟥 | | functions_1.test.w -t tf-aws | 861ms±4.34 | 877ms±3.69 | +16ms (+1.82%)⬜ | ⬜ Within 1.5 standard deviations 🟩 Faster, Above 1.5 standard deviations 🟥 Slower, Above 1.5 standard deviations _Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI._

Results

|name|mean|min|max|moe|sd| |----|----|----|----|----|----| |version|56ms|56ms|57ms|0ms|0ms| |hello_world.test.w -t sim|417ms|404ms|459ms|11ms|16ms| |hello_world.test.w -t tf-aws|1519ms|1504ms|1536ms|7ms|10ms| |jsii_small.test.w -t sim|385ms|374ms|394ms|5ms|7ms| |jsii_small.test.w -t tf-aws|619ms|602ms|670ms|14ms|19ms| |jsii_big.test.w -t sim|3025ms|2984ms|3078ms|22ms|31ms| |jsii_big.test.w -t tf-aws|3229ms|3186ms|3282ms|19ms|27ms| |empty.test.w -t sim|379ms|370ms|388ms|4ms|6ms| |empty.test.w -t tf-aws|617ms|601ms|632ms|7ms|9ms| |functions_10.test.w -t sim|521ms|507ms|534ms|8ms|11ms| |functions_10.test.w -t tf-aws|2278ms|2252ms|2307ms|12ms|16ms| |functions_1.test.w -t sim|423ms|418ms|436ms|4ms|6ms| |functions_1.test.w -t tf-aws|877ms|872ms|888ms|4ms|5ms|

Last Updated (UTC) 2024-10-01 14:20

tsuf239 commented 1 month ago

sdk test run: https://github.com/winglang/wing/actions/runs/11124550295 All passed :)

tsuf239 commented 1 month ago

another workflow run after a small change: https://github.com/winglang/wing/actions/runs/11127000644

winglang / wing