With v. 3.3.4 lots of special characters become �-symbols again

[Dragodraki]

Until v.3.3.3 Wingman Jr. had lots of exceptions so this bug was very rare, but with 3.3.4 this issue appeared again. On lots of websites and even the browser tab names special characters like "ä", "ö", "ü", "ß", chinese, japanese and probably some other are replaced with "�" character.

Fonts shouldn't be changed by this addon in such a way. Maybe you can fix this in general or at least make it as stable as in previous version. Here are some websites as samples: https://www.deepl.com/de/translator https://www.fakt-software.com/index_de.html https://aikasacolle.itch.io/mizuchi https://abbyhoward.itch.io/scarlet-hollow https://www.sparen-wie-schwaben.de https://www.windows-faq.de https://karrierebibel.de

[wingman-jr-addon]

@Dragodraki I'll have to take a look. I worked on fixing it in v3.3.4 but sounds like it made it worse. You can see the details here: https://wingman-jr.blogspot.com/2023/05/release-334-revenge-of-character.html

In particular to fix the issue I needed to default to iso-8859-1 and then "upgrade" to UTF-8. This means that the plugin default is less likely to match the web default, which could be causing new regressions. It's unfortunate because I specifically tested this against an older W3C charset encoding test suite and it now passes all of those where previously it did not. It also passed the website that was problematic as listed by Drago (perhaps you?) on the original bug report in the reviews area.

However, it is clearly lacking in real world international results. I'll need to dig into it and tell you what i find. Thanks for the bug report.

[wingman-jr-addon]

Notes on causes: https://www.deepl.com/de/translator - Meta variant: https://www.fakt-software.com/index_de.html - Meta variant pattern https://aikasacolle.itch.io/mizuchi - Meta variant https://abbyhoward.itch.io/scarlet-hollow - Meta variant https://www.sparen-wie-schwaben.de/ - Meta variant https://www.windows-faq.de/ - Meta variant https://karrierebibel.de/ - Meta variant

These are all variant on the same root cause; I'm going to try a more flexible meta regex detector in the sniffing.

[wingman-jr-addon]

@Dragodraki I have a proposed fix in the linked PR. I need to let it settle a bit to make sure I didn't break other things but it was able to successfully pass all of the above meta variants observed.

[Dragodraki]

Thank you very much for your fast reply, the solution and non-stop support! That makes your addon even more useful :) There is no need to hurry, take your time for testing.

Am 04.06.2023 um 06:03 schrieb wingman-jr-addon:

@Dragodraki https://github.com/Dragodraki I have a proposed fix in the linked PR. I need to let it settle a bit to make sure I didn't break other things but it was able to successfully pass all of the above meta variants observed.

— Reply to this email directly, view it on GitHub https://github.com/wingman-jr-addon/wingman_jr/issues/194#issuecomment-1575368645, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASJ246JA5WJ5CKVWRYZM6M3XJQCI3ANCNFSM6AAAAAAYSXVD6E. You are receiving this because you were mentioned.Message ID: @.***>

-- Diese E-Mail wurde von Avast-Antivirussoftware auf Viren geprüft. www.avast.com

[wingman-jr-addon]

Closing with #195