search

wingman-jr-addon / wingman_jr

This is the official repository (https://github.com/wingman-jr-addon/wingman_jr) for the Wingman Jr. Firefox addon, which filters NSFW images in the browser fully client-side: https://addons.mozilla.org/en-US/firefox/addon/wingman-jr-filter/ Optional DNS-blocking using Cloudflare's 1.1.1.1 for families! Also, check out the blog!
https://wingman-jr.blogspot.com/
Other
35 stars 6 forks source link

Only make menus when it can (Allows running on mobile) #198

Closed arthurmelton closed 8 months ago

arthurmelton commented 8 months ago

I was trying to run this on the mobile version of firefox and saw that the extension was not working. It ended up being that it was trying to make context menus, but you cant on mobile so it would crash. This fixes that, so it only makes the context menus if it can. It looks like the extension works like normal, the only thing that I see not working is hiding the runner tab, but it looks like there is nothing that can be done about it as its not supported on mobile firefox.

wingman-jr-addon commented 8 months ago

@arthurmelton Sorry for the delayed response! I haven't really tried to do much testing for Firefox Mobile, but it seems like with Mozilla's recent release of the many addons that now might be a good time. Thanks for the PR! I had loaded up the addon once on mobile, but in general addons weren't a great experience. How was it when you tried it now? Also, is your phone fairly powerful? I have no idea how the model will perform on mobile devices but with it being EfficientNet Lite based I would imagine it would do OK.

arthurmelton commented 8 months ago

I was running it on a pixel 6a + wasm only. I don't really know how that compares to other devices, it preformed perfectly though. If a pixel 6a is good cpu wise, using the GPU on lower end phones should make it fast also.

Extensions on mobile work really well, if you use one of the 500 or so vetted ones. If you try using a different extensions than the ones provided it is a little bit of a pain. Once you understand how to get one "other" extension on then its easy to add other ones.