wingman-jr-addon / wingman_jr

This is the official repository (https://github.com/wingman-jr-addon/wingman_jr) for the Wingman Jr. Firefox addon, which filters NSFW images in the browser fully client-side: https://addons.mozilla.org/en-US/firefox/addon/wingman-jr-filter/ Optional DNS-blocking using Cloudflare's 1.1.1.1 for families! Also, check out the blog!
https://wingman-jr.blogspot.com/
Other
35 stars 6 forks source link

Feature request: disable with a single click #66

Closed stephen-farris-jhuapl-edu closed 4 years ago

stephen-farris-jhuapl-edu commented 4 years ago

Could you add an option to disable Wingman with a single click, e.g. with a Disabled menu option above Trusted? I only use the software when searching stock photo sites for stock photos to use in presentations and the like, so I don't need to use Wingman most of the time. It would be great to be able to quickly turn it off so false positives don't cause problems when I don't need to use the tool, and turn it back on when I do. It's a great tool, and this would make it even better!

wingman-jr-addon commented 4 years ago

Hey @stephen-farris-jhuapl-edu I think that's a great feature request. The only thing I might want to balance it out against is the fact that I think some folks might use this for their kids, and I don't particularly want a nice easy button for the kids to click just by exploring the interface. Still, I know I've wanted this feature, too. So how about this - what if I added a feature in settings labeled "Show on/off button" and then if that's turned on it'll show up in the menu. Great for those that know, while not very discoverable by kids. Sound reasonable?

stephen-farris-jhuapl-edu commented 4 years ago

That sounds like a great compromise!

From: wingman-jr-addon notifications@github.com Sent: Tuesday, September 8, 2020 12:21 AM To: wingman-jr-addon/wingman_jr wingman_jr@noreply.github.com Cc: Farris, Stephen A. Stephen.Farris@jhuapl.edu; Mention mention@noreply.github.com Subject: [EXT] Re: [wingman-jr-addon/wingman_jr] Feature request: disable with a single click (#66)

APL external email warning: Verify sender noreply@github.commailto:noreply@github.com before clicking links or attachments

Hey @stephen-farris-jhuapl-eduhttps://github.com/stephen-farris-jhuapl-edu I think that's a great feature request. The only thing I might want to balance it out against is the fact that I think some folks might use this for their kids, and I don't particularly want a nice easy button for the kids to click just by exploring the interface. Still, I know I've wanted this feature, too. So how about this - what if I added a feature in settings labeled "Show on/off button" and then if that's turned on it'll show up in the menu. Great for those that know, while not very discoverable by kids. Sound reasonable?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/wingman-jr-addon/wingman_jr/issues/66#issuecomment-688609094, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AG6ZF3CVRHPKDLLFYIFFTYDSEWWLBANCNFSM4PT4XLGQ.

wingman-jr-addon commented 4 years ago

Tinkering on this a bit over here. I hadn't done much with the UI part in this project yet and the need to do everything via RPC means it's bad and hacky right now. Debating if I want to put in a proper solution now or wait until thing number three comes along in the UI.

At any rate, I'm guessing the desired behavior would be to keep the model loaded and warmed up so it's fast to turn it back on. Going with that approach for now.

wingman-jr-addon commented 4 years ago

See #68

wingman-jr-addon commented 4 years ago

This is now out in release 1.2.0 @stephen-farris-jhuapl-edu - give it a try! It won't win any visual design awards but should do what you'd like.

stephen-farris-jhuapl-edu commented 4 years ago

It looks good, thanks!

wingman-jr-addon commented 4 years ago

Great! I like to hear how people actual end up using the plugin, so keep the feedback coming - I appreciate it. Thanks!