search

wingolab-org / mpd-perl

Multiplex Primer Design
GNU General Public License v3.0
11 stars 6 forks source link

Add 2000bp size check for raw bed class #5

Closed Jmeigs1 closed 5 years ago

Jmeigs1 commented 5 years ago

Notes:

  1. Should a similar check be added for the covered class? Based on my understanding the covered class represents the output where the raw class is the input so I imagine the constraints might be different.

  2. The end result of these "fatal" errors is that the line is excluded from the bed file that is eventually passed to the c binary and execution continues. Is this reasonable? Based on the name alone it seems like execution should stop and report an error to the user. Does it make sense high level to return a partial solution for the bed lines devoid of clerical errors?

Jmeigs1 commented 5 years ago

@wingolab Please don't close. The code is not merged into the main repo and there are unaddressed concerns from my original post.

wingolab commented 5 years ago

Thank you. That was an accident.

Jmeigs1 commented 5 years ago

Don't need check for covered class. Confirmed fatal error should prevent further computation. Marked the try catch capturing the error for future review.