Implement IPC::Run to run C binary with timeout

wingolab-org / mpd-perl

Multiplex Primer Design

GNU General Public License v3.0

11 stars 6 forks source link

Implement IPC::Run to run C binary with timeout #6

Closed Jmeigs1 closed 1 year ago

Jmeigs1 commented 5 years ago

Run linter, refactor and add to PrimerDesign test, setup dist:zilla to package via cpan file

akotlar commented 5 years ago

Looks good; at a high level I would prefer this to have been 2 PRs: formatting / linter changes, and then timeout / IPC

Jmeigs1 commented 5 years ago

Linting as part of CI has been drilled into me. Apologies for the clutter.

A linting PR is overkill I think but should have probably been a separate commit or pushed directly. Reviewing with linting changes is a headache. Will keep in mind.