Support Sass v3.2 - Githubissues

wingrunr21 / flat-ui-sass

Designmodo's Flat-UI ported to SASS with support for Flat-UI Pro

MIT License

156 stars 44 forks source link

Support Sass v3.2 #15

Closed wingrunr21 closed 10 years ago

wingrunr21 commented 10 years ago

As of commit 0fcdff8, sass-rails now explicitly precludes Sass v3.3+ from installation. This is a blocker for those attempting to use this gem along with the latest versions of Rails.

Two areas need modified in order to relax the Sass requirement:

The asset helper function needs to be reverted to the method used by bootstrap-sass
The interpolate_variable function will need to be modified to support Sass 3.2. This will affect the calc-color mixin and subsequently the palette module.

akshatpradhan commented 10 years ago

Just a heads up, we're currently using the 3.2. branch and its been deployed to production. https://github.com/akshatpradhan/compliance_chimp/blob/master/Gemfile#L12

wingrunr21 commented 10 years ago

Awesome thanks. I will need to test against Flat UI free then I will merge into master.

FYI you realize you have Flat UI Pro checked into and available from a public repo right? Not sure Designmodo will appreciate that.

akshatpradhan commented 10 years ago

yeah I have my own set off issues with him and I can't wait to move away from Flat UI the first chance I get. He's antithetical to the very notion of community and his licensing is absurd: https://github.com/designmodo/Flat-UI/issues/124

We noted that in our commit and we've specifically pointed to the PR that verifies we own a developers licenses to Flat UI Pro: https://github.com/akshatpradhan/compliance_chimp/pull/61

The Highcharts licensing methodology IS the best way to license Flat UI (and make money) but he won't read up on it.

wingrunr21 commented 10 years ago

I will test Flat UI Free later today and hopefully merge 3.2 support into master later tonight.