wingrunr21 / flat-ui-sass

Designmodo's Flat-UI ported to SASS with support for Flat-UI Pro
MIT License
156 stars 44 forks source link

Don't load rake task unless on a supported Ruby #30

Closed mlarraz closed 10 years ago

mlarraz commented 10 years ago

The flatui-pro:convert Rake task is the only one in this gem (or bootstrap-sass) that gets loaded directly into the Rails app.

It depends on several scripts in bootstrap-sass that otherwise don't get loaded. One of these uses keyword arguments, a language feature only supported on MRI 2.x.

This wraps the loading of the Rake task in a conditional, so people still on MRI 1.9.3 (or other rubies, like Rubinius) can still use the rest of the gem.

wingrunr21 commented 10 years ago

Ok, one thing I would ask is that you add a note to the README stating that the rake task will no longer be available to you if you are running a non-compatible Ruby.

mlarraz commented 10 years ago

I went ahead and added something to the Flat-UI Pro section.

wingrunr21 commented 10 years ago

Thanks