search

wingrunr21 / gitolite

A Ruby interface for the gitolite git backend system
https://github.com/wingrunr21/gitolite
MIT License
82 stars 37 forks source link

Rails 3.2 #19

Closed dzaporozhets closed 12 years ago

dzaporozhets commented 12 years ago

This issue related to one of dependencies gem. Feel free to close it.

But this is a reason why i cant use your gem v1.x for GITLAB.

You have a plexus gem dependency. Which depends on facets. https://github.com/rubyworks/facets/issues/55

So after update to gitolite v1.0 i cant start my application. Sorry if I am wrong & missed something

wingrunr21 commented 12 years ago

Ok I will look into it.

dzaporozhets commented 12 years ago

Maybe fixed https://github.com/rubyworks/facets/issues/55#issuecomment-5958650

wingrunr21 commented 12 years ago

Ok, it looks like the solution, for the time being, is probably going to be putting facets before gitolitein the Gemfile

gem 'facets', :git => 'git://github.com/rubyworks/facets.git'
gem 'gitolite'

plexus does not depend on a specific version of facets so I believe that will fix the issue. You could fork facets or lock the Gemfile to a specific SHA if you are worried about things breaking via installing facets from git.

wingrunr21 commented 12 years ago

facets appears to be compatible now. plexus, however, is not.

plexus Issue #2 deals with the issue

dzaporozhets commented 12 years ago

So i still wont be able to use it, right?

wingrunr21 commented 12 years ago

It looks like the issue with plexus has not been looked at. I will take a look tonight and either see if I can fix the problem or look into a different graph library (gratr19 may be an option).

wingrunr21 commented 12 years ago

I found the plexus issue. I have fixed it but, due to their test suite not passing, can't tell if I further broke things or if things are the same.

julionc commented 12 years ago

This has been working great but today I updated Rails to 3.2.8 which the stopped one app from working instead returning an actionpack error. ¿?

Anyway, I've solved it (apparently)

gem 'gitolite', :github => 'wingrunr21/gitolite', :require => false
wingrunr21 commented 12 years ago

That actually doesn't solve the issue, it just prevents the gem from being required. Once the gem gets required into Rails you'll see issues.

wingrunr21 commented 12 years ago

version 1.1.0 fixes this issue by switching from using plexus to the gratr19 library.

dzaporozhets commented 12 years ago

@wingrunr21 so i can finally your gem instead of our fork for gitlab? :)

wingrunr21 commented 12 years ago

Hopefully