search

wingspan / wingspan-forms

A dynamic form library for Facebook React, providing abstractions for building dynamic forms and controlled grids. Widgets provided by Telerik's KendoUI.
MIT License
292 stars 25 forks source link

Sync component names with kendo widget names #58

Closed newyankeecodeshop closed 9 years ago

newyankeecodeshop commented 10 years ago

KendoDate -> KendoDatePicker KendoDatetime -> KendoDateTimePicker KendoTime -> KendoTimePicker KendoNumber -> KendoNumericTextBox KendoText -> TextBox (not actually a kendo-based widget)

dustingetz commented 10 years ago

TextBox does use the k-textbox class or something like that

newyankeecodeshop commented 10 years ago

True, but MultilineText and TabStrip also use "k-" class names, but they don't have Kendo prefixes. I assumed that it's more about whether a widget is being wrapped.

dustingetz commented 10 years ago

hmm. Maybe they should. I'm mostly thinking ahead about making it clear which bits require kendo (js or css) on the page.

dustingetz commented 10 years ago

Probably we should reconfigure the require shims, so that we can have a 'kendo' directory, and not include 'kendo' in any control names, just have them in that kendo "namespace".

newyankeecodeshop commented 10 years ago

It would probably be better to remove the default "k-" class names for non-kendo widgets. Most of our widgets take className as a prop, so folks can use "k-" classes if they use kendo elsewhere. I like the idea to reconfigure the shims. I don't understand it enough to know how to do it.