wingsuit-designsystem / wingsuit

Twig for Storybook
GNU General Public License v2.0
92 stars 16 forks source link

Running "attachBehaviors" after react component is rendered #106

Closed christianwiedemann closed 3 years ago

christianwiedemann commented 3 years ago

This pr changes the way attachBehaviors is called. Currently attachBehaviors is implemented as Storybook decorator. Now attachBehavior is called after the react component is completely rendered. Also after changing props via knobs. No hacky setTimeout is needed any more.

codecov[bot] commented 3 years ago

Codecov Report

Merging #106 (bc6dec7) into master (95735e6) will not change coverage. The diff coverage is 40.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #106   +/-   ##
=======================================
  Coverage   60.83%   60.83%           
=======================================
  Files          24       24           
  Lines         623      623           
  Branches      122      122           
=======================================
  Hits          379      379           
  Misses        199      199           
  Partials       45       45           
Impacted Files Coverage Δ
packages/core/src/index.ts 21.42% <0.00%> (ø)
packages/core/src/server/plugins/Svg2JsonPlugin.ts 30.43% <0.00%> (ø)
packages/pattern/src/twigExtensions.ts 0.00% <0.00%> (ø)
packages/pattern/src/twigRenderEngine.ts 72.50% <ø> (ø)
packages/pattern/src/PatternStorage.ts 22.66% <11.11%> (ø)
packages/core/src/server/presets/assets.ts 60.00% <100.00%> (ø)
packages/core/src/server/presets/assetsVideos.ts 62.50% <100.00%> (ø)
packages/pattern/src/Setting.ts 76.47% <100.00%> (ø)
packages/pattern/src/TwigAttribute.ts 71.15% <100.00%> (ø)
packages/pattern/src/TwingRenderer.ts 86.20% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 95735e6...bc6dec7. Read the comment docs.