wingsuit-designsystem / wingsuit

Twig for Storybook
GNU General Public License v2.0
93 stars 16 forks source link

Replace Swiper library with tiny-swiper which a lot lighter #107

Closed GiorgosK closed 3 years ago

GiorgosK commented 3 years ago

and also has exactly the same API

I had to run git commit -m 'message' --no-verify with --no-verify as I was getting an error along the lines of this

✖ 1 problem (1 error, 0 warnings)

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. error Command failed with exit code 1. error Command failed with exit code 1. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. husky > pre-commit hook failed (add --no-verify to bypass) git config --get-all user.name git config --get-all user.email git ls-tree -l HEAD -- /home/giorgos/share/gwebsites/wingsuit/starter-kits/tailwind/yarn.lock git ls-files --stage -- /home/giorgos/share/gwebsites/wingsuit/starter-kits/tailwind/yarn.lock git cat-file -s 0168868890221583bbeee182d8346e531b812c83

Otherwise the swiper seems to work as expected

related to #84 issue

NOTE1: Not sure how to get rid of the swiper library from the root yarn.lock

NOTE2: eslint still complains about not being able to find the library, but I have not downgrade yarn as instructed on #84 (could that be the problem?), even after running the following command warning did not go away.

module "/home/projects/wingsuit/node_modules/tiny-swiper/lib/index.min" 'tiny-swiper' should be listed in the project's dependencies. Run 'npm i -S tiny-swiper' to add iteslintimport/no-extraneous-dependencies

christianwiedemann commented 3 years ago

Thanks! Will check your PR. Will merge it in an extra branch. The problems with pre commit hooks are strange. Will let you know.