wingsuit-designsystem / wingsuit

Twig for Storybook
GNU General Public License v2.0
91 stars 16 forks source link

Documentation correction for Pattern twig functions #171

Closed jowan closed 2 years ago

jowan commented 3 years ago

In the docs: https://wingsuit-designsystem.github.io/components/presentation/#additional-twig-functions

pattern_preview(patternId, variantId, variables) and pattern(patternId, variantId, variables)

should be:

pattern_preview(patternId, variables, variantId) and pattern(patternId, variables, variantId)

respectively. Which closely follows :

https://ui-patterns.readthedocs.io/en/8.x-1.x/content/developer-documentation.html#render-patterns-using-twig-functions

However, Patterns UI does not support vars in pattern_preview, and I'd suggest dropping that parameter to maintain compatibility.

The below works for me:

{# TEMPLATE #}
<div id="ac-{{ pid }}" class="accordion">
  {% for item in items %}
    {% set vars = {
      "aiid": item.aiid,
      "pid": pid,
      "label": item.label,
      "content": item.content,
      "toggle": toggle,
    } %}
    {{ pattern('bs_accordion_item', vars, '__default') }}
    {{ pattern_preview('bs_accordion_item', vars, '__default') }}
  {% endfor %}
</div>