Closed christianwiedemann closed 4 years ago
Merging #56 into refactor_patterns will increase coverage by
0.23%
. The diff coverage is70.58%
.
@@ Coverage Diff @@
## refactor_patterns #56 +/- ##
=====================================================
+ Coverage 59.29% 59.53% +0.23%
=====================================================
Files 27 27
Lines 624 640 +16
Branches 118 121 +3
=====================================================
+ Hits 370 381 +11
- Misses 212 217 +5
Partials 42 42
Impacted Files | Coverage Δ | |
---|---|---|
packages/pattern/src/twigRenderEngine.ts | 72.50% <55.55%> (-2.15%) |
:arrow_down: |
packages/pattern/src/PatternVariant.ts | 75.00% <66.66%> (-0.48%) |
:arrow_down: |
packages/pattern/src/Pattern.ts | 67.77% <100.00%> (+1.11%) |
:arrow_up: |
packages/pattern/src/TwingRenderer.ts | 91.42% <100.00%> (+0.25%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update c5a92a5...2908c01. Read the comment docs.
Having had a 2nd thought about this I think the UX is improved if you move the configuration into the wingsuit.yml file. Configuration is more like the pattern settings and it probably makes sense to put it in the wingsuit.yml file.
Right now configuration is done inside the pattern. For example the grid template:
This PR moves this configuration to
wingsuit.yml
. Sample YAML:Access You can access the configuration with a twig function: To access the columns configuration
pattern_configuration('gird', 'column_2','columns')