search

wingtk / gvsbuild

GTK stack for Windows
GNU General Public License v2.0
413 stars 160 forks source link

libadwaita 1.4 isn't buildable with Gvsbuild #1075

Closed danyeaw closed 5 months ago

danyeaw commented 9 months ago

libadwaita now depends on AppStream AppStream depends on libxmlb libxmlb makes use of g_autoptr, which isn't supported with MSVC.

So we have no upgrade path with libadwaita unless we can work with the other projects to:

  1. Make the AppStream dependency optional
  2. Allow use of a different xml library in AppStream (I'm not sure how feasible this is)
  3. Remove use of g_autoptr in libxmlb
danyeaw commented 9 months ago

The other option may be to use clang-cl.exe for building.

danyeaw commented 9 months ago

@fanc999 I know you have been experimenting with clang-cl for glib builds. Do you think this is the direction we should be heading?

nacho commented 9 months ago

Dan I think we should start by filing a ticket to libadwaita. Do you have already a ticket upstream?

danyeaw commented 9 months ago

https://gitlab.gnome.org/GNOME/libadwaita/-/merge_requests/833

https://gitlab.gnome.org/GNOME/libadwaita/-/issues/659

danyeaw commented 5 months ago

Closed by #1076. It would still be nice to be able to build Appstream for Windows so that we don't need to patch libadwaita, but we don't need an open issue for that.