add loadSecureUrls props to resolve mixed content issue

winhtaikaung / react-tiny-link

Convert your links into rich previews

https://winhtaikaung.github.io/react-tiny-link

259 stars 48 forks source link

add loadSecureUrls props to resolve mixed content issue #45

Closed sndsabin closed 4 years ago

sndsabin commented 4 years ago

add onlySecure props

if true, loads only secure ( https:// ) resources. If no secure resource was found, then <img> and <video> element wont be rendered
default false works as before

`http` Video Url Example

With `onlySecure={false}`

works exactly as before

Screenshot from 2020-03-25 00-30-56

Screenshot from 2020-03-25 00-31-25

With `onlySecure={true}`

No video tag present in DOM

Screenshot from 2020-03-25 00-31-45

Screenshot from 2020-03-25 00-32-20

P.S: Always loads resources over https whenever possible.

winhtaikaung commented 4 years ago

Hi @sndsabin I 've created a branch for your changes with the name of sndsabin/master please checkout from it and send PR to that sndsabin/master branch again. :pray: Sorry for inconvenicence

sndsabin commented 4 years ago

@winhtaikaung a new PR is open for this same changes https://github.com/winhtaikaung/react-tiny-link/pull/46

winhtaikaung / react-tiny-link

add loadSecureUrls props to resolve mixed content issue #45

http Video Url Example

With onlySecure={false}

With onlySecure={true}

`http` Video Url Example

With `onlySecure={false}`

With `onlySecure={true}`