search

winhtaikaung / react-tiny-link

Convert your links into rich previews
https://winhtaikaung.github.io/react-tiny-link
259 stars 48 forks source link

Bundle size & duplicate react-dom.production #74

Closed anuraghazra closed 4 years ago

anuraghazra commented 4 years ago

Hi, thank you for the amazing lib. it works super nicely.

but i only have one issue with it, is that the bundle size is too large.. i don't know if something is wrong or i'm doing something wrong the size is around 190kb and it also includes react-dom.production for some reason.

image

winhtaikaung commented 4 years ago

Hello @anuraghazra, Thanks for reporting that issue , I 've moved the react & react-dom to peerdependencies. Once the #75 was published by next week you may try it again.

anuraghazra commented 4 years ago

Hi @winhtaikaung thanks for the swift response and fix.

Btw it also uses the styled-components right? so i think it should also be moved to peerdependencies?

because looking at my bundle analyzer i think i also have duplicate styled-component.

winhtaikaung commented 4 years ago

Hi @winhtaikaung thanks for the swift response and fix.

Btw it also uses the styled-components right? so i think it should also be moved to peerdependencies?

because looking at my bundle analyzer i think i also have duplicate styled-component.

:thinking: Ok I put it as some project might not use styled-components. Let me check