TheWrathOfConst
commented
9 years ago Hey there, @Ty3uK. Thanks for your pull request!
The problem with the change you're proposing is that it's modifying temporary WinJS files. This bridge was built for WinJS 4.0, and since we didn't have 4.0 in any package managers at the time we released it, we added the external folder with a WinJS 4.0 build in it so that we'd be unblocked at the time (see angular-winjs/external/readme.md). We're planning to remove the external directory and pull WinJS from a package manager at some point in the future (issue #13 is opened right now for that), so unfortunately that means the changes you've proposed here would be totally lost when we moved.
I'd like to know a little more about the bug you're fixing here. Is this intended to fix issue #17, or a different issue altogether? Would you mind opening an issue for the bug so we can take a look at it?
Ty3uK
Hi @Ty3uK, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.
TTYL, MSBOT;