winjs / angular-winjs

Project to smooth the AngularJS/WinJS interaction
Other
126 stars 46 forks source link

When clicking on rating stars, our UI is not updating on first click. #68

Closed tyroneallen281 closed 9 years ago

tyroneallen281 commented 9 years ago

Code:

We are experiencing an issue that when a user clicks on the rating stars for the first time after page load the rating object does not show this rating, it seems to be caused but the following in your code.

_onUserRatingChanged: function () {
                    if (!this._disabled) {
                        this._closeTooltip();
                        // Only submit a change event if the user has altered the rating control value via PREVIEWCHANGE event.
                        if (this._userRating !== this._tentativeRating && !this._lastEventWasCancel && !this._lastEventWasChange) {
                            this.userRating = this._tentativeRating;
                            this._raiseEvent(CHANGE, this._userRating);
                        } else {
                            this._updateControl();
                        }
                    }
                }

The if (this._userRating !== this._tentativeRating part of the If is false causing the system to not update.

I am not sure why this is please look into it as help asap.

Regards Tyrone

jdalton commented 9 years ago

Unfortunately it doesn't look like I'll have the time to investigate. However, please feel free to update the issue any further findings.