search

winjs / angular-winjs

Project to smooth the AngularJS/WinJS interaction
Other
126 stars 46 forks source link

Support for Angular 1.4/1.5 #88

Closed albatrosary closed 8 years ago

albatrosary commented 8 years ago

Hi.

Now Angular version is 1.3, do you have any plans to 1.4 / 1.5? It is an error if run in 1.5. I want you to the version up.

Thank you.

jdalton commented 8 years ago

Related to #86.

sondreb commented 8 years ago

One bug with 1.5 is that the split view adds ="true" on the win-pivot. Angular 1.5 supports named transcludes, so it looks for an element named "true". ng-transclude should not set to true, only add the attribute without content.

Error: [$compile:noslot] No parent directive that requires a transclusion with slot name "true". Element: <div ng-transclude="true"
AndreasM009 commented 8 years ago

Hi, I currently updated my application to AngularJS 1.5.3. It seems that the WinJS ListView does not work with AngularJS 1.5.3. I get the following error when Angular tries to compile win-list-view directive: Error: [$compile:noslot] http://errors.angularjs.org/1.5.3/$compile/noslot? .... Any ideas?

Thank you

DimiGrigoriadis commented 8 years ago

With introduction of AngularJS 1.5.x transclusion was changed to support the long awaited multi-transcludes. Since ListView adds transclude=true, Angular is looking for the transclude slot named "true". See @sondreb explanation. So you should use a version < 1.5.x. I'm using 1.4.8 and everything works fine.

sensiblearts commented 8 years ago

I just froze a copy of angular-winjs.js and did a search and replace: // replaced: ng-transclude='true' // with: ng-transclude

Seems to work fine.

humale commented 8 years ago

@albatrosary thanks for the question! It's been answered here: https://github.com/winjs/winjs/issues/1622#issuecomment-213136589

albatrosary commented 8 years ago

@humale thank you! Take a look at.