search

winjs / react-winjs

React wrapper around WinJS's controls
MIT License
206 stars 47 forks source link

AppBar broken in latest build #15

Closed darkyen closed 9 years ago

darkyen commented 9 years ago

Appbar renders as empty in the latest build. The underlying .winControl gets the commands but they aren't visible.

AmazingJaze commented 9 years ago

Hi @darkyen, thank you for the issue, can you clarify which version of WinJS and which version of react-winjs you are using?

I will have to double check, but I believe that angular-winjs and react-winjs are both still only compatible with WinJS 4.0 preview and that both will be updated to WinJS 4.0 shortly after it releases.

darkyen commented 9 years ago

Oh its on master from both (but any version after the preview will break this for react-winjs because of some change in appbar behavior), i just cloned to ensure i am at the tip, as i understand though AppBarButton's componentDidMount never fires which causes the button to never mount in the component and @AmazingJaze thanks for the heads up :-), I am trying to patch react-winjs so that it works with WinJS 4.0 final version, we are launching an app which is using winjs 4.0 + react.

I can't understand though why it works on preview but not on master as in componentDidMount should never fire in both cases.

AmazingJaze commented 9 years ago

There are a few breaking API name changes in between WinJS 4.0 preview and WinJS 4.0, particularly in AppBar, ToolBar, NavBar, and SplitView controls so you may be running into something related to that. Their were a lot of underlying architectural changes in those controls as well to accommodate new UI design changes. AppBar has changed most of all.

Specificially for AppBar and off the top of my head: -hide() & show() methods were renamed to open() & close() -showCommands() and hideCommands() were removed in favor of the ubiquitous showOnlyCommands() -"layout" property was removed. -"disabled" property was removed. -"sticky" property was removed in favor of new AppBar.closedDisplayMode = "full" pattern. -"hidden" property was renamed to "opened" and its logical meaning is flipped and it is now a getter and a setter -'commands' property was replaced with the data property. The data property is get and set, and is of type WinJS.Binding.List

My understanding is that we will be releasing an official list of changes to WinJS 4.0 in the not so distant future.

Sent from Windows Mail

From: Abhishek Hingnikarmailto:notifications@github.com Sent: ?Monday?, ?June? ?1?, ?2015 ?7?:?22? ?PM To: winjs/react-winjsmailto:react-winjs@noreply.github.com Cc: Jesse Sharpmailto:jessesh@microsoft.com

Oh its on master from both, i just cloned to ensure i am at the tip, as i understand though AppBarButton's componentDidMount never fires which causes the button to never mount in the component and @AmazingJazehttps://github.com/AmazingJaze thanks for the heads up :-), I am trying to patch react-winjs so that it works with WinJS 4.0, we are launching an app which is using winjs 4.0 + react

Reply to this email directly or view it on GitHubhttps://github.com/winjs/react-winjs/issues/15#issuecomment-107774371.

darkyen commented 9 years ago

@AmazingJaze you are amazing :-) thank you so much for the insight, patched it up on my fork, will send a pr after doing some more changes (as many as i can track)

AmazingJaze commented 9 years ago

@darkyen Did this resolve your original AppBar issue?

darkyen commented 9 years ago

Yep thank you so much :+1: