search

winjs / react-winjs

React wrapper around WinJS's controls
MIT License
206 stars 47 forks source link

peerDependencies "react" version confict #7

Closed quanglam2807 closed 9 years ago

quanglam2807 commented 9 years ago

I am developing the app with ES6, so I need to use 0.13.x (as 0.12.x does not support ES6). And also some dependencies, such as react-router does not support 0.12.x in it package.json and it causes problems:

npm ERR! peerinvalid The package react does not satisfy its siblings' peerDepend
encies requirements!
npm ERR! peerinvalid Peer react-router@0.13.3 wants react@0.13.x
npm ERR! peerinvalid Peer react-winjs@0.2.1 wants react@^0.12.2

To resolve this issue, as @fmpublic suggested, we should use range for "react" instead. So everyone is happy :dancer: .

fmpublic commented 9 years ago

with npm@3, we have problems with peerdependencies https://docs.npmjs.com/files/package.json#peerDependencies However, dependencies seems to work just fine with any version of npm. I propose we simply change the peerDependencies to the following:

"dependencies": { "react": ">=0.12.2" }

quanglam2807 commented 9 years ago

@fmpublic I have updated PR will your suggestion :+1:

darkyen commented 9 years ago

the npm version is still outdated