search

winjs / winstrap

The official Bootstrap theme for Microsoft's Modern design language
http://winstrap.azurewebsites.net
Other
533 stars 122 forks source link

Include Pre-Built bower package Resolution #127

Closed edrohler closed 8 years ago

edrohler commented 8 years ago

Added a dist folder for bower deployment since npm will pull down the entire repo. Also we can also use jspm if we decide to.

There are 2 new folders added www and dist. The dist folder is used for distributing the packages on bower. The www folder is for testing the doc compilation and deploying to azure websites.

Lastly, I found an issue with running build with winstrap as a git submodule. We don't actually need to use bower to manage dependencies since NPM is already doing that. So, I changed the reference in the grunt file to use node_modules instead of bower_packages and the build works fine as a submodule.

msftclas commented 8 years ago

Hi @edrohler, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

msftclas commented 8 years ago

@edrohler, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;

edrohler commented 8 years ago

@mlijanto This should be all set now :)

mlijanto commented 8 years ago

@edrohler Great! Thanks for the PR!