winjs / winstrap

The official Bootstrap theme for Microsoft's Modern design language
http://winstrap.azurewebsites.net
Other
533 stars 122 forks source link

Why is navbar collapse set on md screen? #138

Open cordasfilip opened 8 years ago

cordasfilip commented 8 years ago

In bootstrap the navbar isn't collapsed on 1024 width where as in winstrap it is. Is there a way to get the default behavior for navbar in winstrap? Also the collapsed navbar doesn't fill the whole width in IE 11?

joetheday commented 8 years ago

Hey @cordasfilip, thanks for the feedback.

I just took a look on IE11 and am seeing it fill full-width, at least inside the padding of it's container. Do you have a more specific example I can take a look at?

As for the breakpoint, our designs require it at 1084, so that'll stay. I think there are a couple override options you could consider:

  1. Override the viewport variables such as '$screen-xs-min' etc... so that the viewport behavior is tuned to your specific need, or
  2. Override the media queries
cordasfilip commented 8 years ago

Thanks for the response What fix my problem was changing $grid-float-breakpoint: $screen-lg-min !default; to $grid-float-breakpoint: $screen-md-min !default; in _variables.scss and regarding the fill I attached two files of my print screens in ie11 nav nav2 I tested it on two computers one 32bit win10 with ie11 (latest updates) and 64bit win10 with ie11 (latest updates) same thing It's happening on http://winstrap.azurewebsites.net/controls.html#navs and not in my local code.

codefactorymx commented 6 years ago

Hi cordasfilip, yes, you're right, I haven't seen that because my desktop is big and in phone looks fine. I'll try to push a fix

codefactorymx commented 6 years ago

Hi cordasfilip, one of my customers got the same issue you're reporting, because they have small screen devices. Have seen into the code and applied a fix.

If you want, you can use my own repository, once Martin can update the official one. https://github.com/codefactorymx/winstrap