winjs / winstrap

The official Bootstrap theme for Microsoft's Modern design language

http://winstrap.azurewebsites.net

Other

533 stars 122 forks source link

fixed toggle switch & import Micon icons #142

Closed xtoolkit closed 8 years ago

xtoolkit commented 8 years ago

fixed toggle switch with stock and animation! i only edit _buttons.scss and build commit! but i don't know why change winstrup.css line 7766 to 7766 and 7767! but good worked :) sketch

Update 20/8/2016

merge Micon icons Instead Glyphs ->change icons name to Official Windows icons name -> import example screenshot 3

msftclas commented 8 years ago

Hi @xtoolkit, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

msftclas commented 8 years ago

@xtoolkit, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;

mlijanto commented 8 years ago

@xtoolkit Thanks for the PR, but we can't accept it because of the addition of new icons. The icons in the WinJS Symbols fonts are the only icons that have been approved by Microsoft design and legal teams to be distributed by Winstrap. If you would like to add new icons, please do so in a separate fork. If you can remove the icons changes from this PR then I would be happy to take a look at your toggle switch changes. Thanks!

xtoolkit commented 8 years ago

hi create pull without micon. link