search

winjs / winstrap

The official Bootstrap theme for Microsoft's Modern design language
http://winstrap.azurewebsites.net
Other
533 stars 122 forks source link

pull for release 0.5.11 version #146

Closed xtoolkit closed 7 years ago

xtoolkit commented 8 years ago

fix button, text input and select style. change border width to 2px. fix toggle switch style and add animation for click. Added new glyphs features. Added WSA List items. Added Put box.

msftclas commented 8 years ago

Hi @xtoolkit, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

mlijanto commented 8 years ago

@xtoolkit, thanks for the PR. Since you are adding new components and controls, we need to review this PR internally with the design team first.

xtoolkit commented 8 years ago

hi i use design of windows setting app... set1 set2

xtoolkit commented 7 years ago

hi! a month passed! what was the result?

mlijanto commented 7 years ago

@xtoolkit, sorry for the delay. We can take a look at accepting the WSA list item and put box controls, but you should not change any of the existing generic styles (border width, etc.) and controls/components because their designs have been approved to follow Microsoft Design Language for web. There are places where the web version of the design language is not an exact match of the OS design language, but those are intentional. Please submit a new PR that contains only the WSA list item and put box controls changes. Thanks.