search

winjs / winstrap

The official Bootstrap theme for Microsoft's Modern design language
http://winstrap.azurewebsites.net
Other
533 stars 122 forks source link

pull for release 0.5.11 version #148

Closed xtoolkit closed 7 years ago

xtoolkit commented 7 years ago

hi change logs:

  1. fix toggle switch style and add animation for click.
  2. Added new glyphs features.
  3. Added WSA List items.
  4. Added Put box.
msftclas commented 7 years ago

Hi @xtoolkit, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

mlijanto commented 7 years ago

@xtoolkit, looks like you copied a substantial amount of code and documentation from font-awesome. They are great features, but we don't want to distribute code from 3rd party projects with Winstrap unless necessary; because that will require an internal legal review and we will have to modify Winstrap license to include the distributed 3rd party code.

Can you please remove all the changes related to font-awesome from this PR? If you need to use it with Winstrap, then perhaps you can include it in your project using npm or other package manager. Thanks.