search

winks-vtt / yze-coriolis

Foundry VTT system for Coriolis
Other
19 stars 28 forks source link

Not all modifiers from Items are shown in rol dialog box #263

Closed theczarek closed 4 months ago

theczarek commented 5 months ago

When rolling a skill only modifier from one item of any given type is shown e.g one Critical injury, one gear one talent of given type. Modifiers from eg. multiple injuries shoud stack up: obraz

IrishWolf commented 5 months ago

Hmm, I can't recreate that problem.

https://github.com/winks-vtt/yze-coriolis/assets/36819852/085d8bbe-a0b7-4854-b8ed-92e5d340aecd

theczarek commented 5 months ago

Drag and drop injury created in reprository. When you add them via "+ADD" button it's ok. But when dragging and droping it remembers only last one droped

IrishWolf commented 5 months ago

hmm, even there I can't reproduce its effect.

Can you press F12 (open console of Foundry) and look if there are any errors or warnings that may be related?

https://github.com/winks-vtt/yze-coriolis/assets/36819852/5ae6fdbc-735b-4026-88c9-6989cd2c7fe4

IrishWolf commented 5 months ago

Okay, with try and error i've got the gist of the problem. If you take the same injury (or item/talent/whatever) multiple times from the same folder/compendium it will have the same ID behind it. As the modifiers are grouped with the respective ID they won't be listed multiple times.

Will look into it, how to tackle that problem. For the meanwhile you can either use the "+ Add" button or drag different items/injuries/talents into the sheet instead of multiple times the same and editing it afterwards.

theczarek commented 5 months ago

Thank You. I've checked, They can be from the same folder (root folder in my case) but cannot be duplicated via RMB option. obraz aaa and bbb were created in via Creare Item option, bbb 2 is duplicate of bbb. All three shows diffrent ID's in top left corner (marked red): aaa: VDzjZmLtvDJ8aAVB bbb: yWc8xtUvJfmksKrl bbb 2: 1lkg1GuwDCdY6YkF

Unless you use some other ID that is duplicated with it's value

Modifiers system can be really useful. (Also great rework of Starship sheet. Debt tracking and list of modules are great)

IrishWolf commented 5 months ago

The problem should be fixxed with #267