search

winlibs / libtidy

6 stars 3 forks source link

libtidy 5.6.0 changes locale #3

Closed cmb69 closed 5 years ago

cmb69 commented 5 years ago

This has been reported as PHP bug 77278. Simple reproducer on a system with a German locale (or any other which uses a comma as decimal separator):

<?php
$val = 4/3;
echo "$val\n";
new tidy;
echo "$val\n";

This gives:

1.3333333333333
1,3333333333333

While this is clearly an upstream issue (htacg/tidy-html5#780), maybe a resonable workaround for now could be to do cmake -DSUPPORT_LOCALIZATIONS=OFF … (tested on Linux; no other regression detected).

weltling commented 5 years ago

Thanks for the ping. The current tag has been rebuilt according to your suggestion, the binaries have been put into staging, so should be included with the upcoming RCs. I didn't document this, as this probably won't be needed when upgrading libtidy later.

Thanks.