winlibs / openldap

Lightweight Directory Access Protocol
Other
16 stars 9 forks source link

Get the DLL release build to export the used symbols, so they can be used for other applications #1

Closed guysoft closed 10 years ago

guysoft commented 10 years ago

Add dllexport macro to export the lber and ldap symbols, and enable those preprocessor definitions in DLL Release build.

Without this the symbols are not exported and no .lib files are created.

weltling commented 10 years ago

Hi,

How do you build it? I've just tried the vc9 project, but it produces the olber32 stuff only. Do I miss something? Some paths need to be adapted, and maybe some lib deps?

Thanks

pierrejoye commented 10 years ago

btw, we hang out on Freenode #winphp-dev if you like support or discuss one issue or another :)

On Thu, Feb 6, 2014 at 1:13 PM, Anatol Belski notifications@github.comwrote:

Hi,

How do you build it? I've just tried the vc9 project, but it produces the olber32 stuff only. Do I miss something? Some paths need to be adapted, and maybe some lib deps?

Thanks

— Reply to this email directly or view it on GitHubhttps://github.com/winlibs/openldap/pull/1#issuecomment-34317511 .

Pierre

@pierrejoye | http://www.libgd.org

guysoft commented 10 years ago

@weltling What do you mean by "produces the olber32 stuff only"? Do you get an error when compiling?

In my project I also had to include olber32.lib in the required libs for ldap, didn't want to include it in here because was trying to make the request as minimal as possible.

weltling commented 10 years ago

@guysoft yeah, that's exactly what it says, like "couldn't find olber32.lib" . As those're actually two projects in the same solution, one could avoid a big change appending someting like below into the additional lib paths in the libldap dll project

$(SolutionDir)....\out\liblber\$(Platform)\$(Configuration);

Mabe also make libldap depend on liblber project. However i you use that projects in some other solution, that might be another story. It's good to have it short of course, just it to be worky out of the box would make sense. As i'll port it up to the vc11 then and for x64.

Thanks

guysoft commented 10 years ago

@weltling Yes I had that added here too, but I thought there might be some configuration that does not need that and will cause things to fail. So didn't add it. I can include that in the pull request.

guysoft commented 10 years ago

@weltling Ok added another commit to this pull request, that should include all the linker requirements. See if that helps (or creates new problems since I also added libsasl.lib and ws2_32.lib)