search

winlibs / wineditline

An EditLine API implementation for the native Windows Console.
Other
21 stars 8 forks source link

extern "C" #4

Closed ms609 closed 5 years ago

ms609 commented 5 years ago

These files end with

#ifdef __cplusplus
}
#endif

but lack the corresponding

#ifdef __cplusplus
extern "C" {
#endif

which we've had to add in order to get wineditline working with a C/C++ project.

weltling commented 5 years ago

Thanks for the patch. readline.h is indeed missing that, but wineditline.h is fine. This should however go upstream /cc @ptosco.

Thanks.

ptosco commented 5 years ago

@weltling @ms609 Done, thanks for the heads-up!

weltling commented 5 years ago

@ptosco thanks for picking up. We currently don't build with C++, that's why it was never revealed. Looks like this can be closed, will sync with teh next upgrade.

Thanks.