winlibs / winlib-builder

MIT License
6 stars 5 forks source link

Don't build *_uwp projects of icu4c #10

Closed cmb69 closed 1 month ago

cmb69 commented 1 month ago

These are superfluous for PHP, and apparently may cause issues[1].

[1] https://github.com/winlibs/winlib-builder/actions/runs/10752666056/job/29821234927#step:7:4613


I've did a test build, and checked that the artifacts are basically the same as without this patch.

An alternative to this could be to exclude the UWP projects from the icu4c repository in the first place. This had the additional advantage that builds not using winlib-builder would not have to build the UWP projects (what requires having UWP support installed in Visual Studio; a couple of additional GBs). The obvious drawback would be that versions already have been commited/tagged would still build the UWP projects.