search

winnekes / itypescript

ITypescript is a typescript kernel for the Jupyter notebook (A modified version of IJavascript)
Other
190 stars 29 forks source link

Gets version for jupyter notebook #14

Closed idantene closed 5 years ago

idantene commented 5 years ago

jupyter --version returns an output such as:

jupyter core     : 4.5.0
jupyter-notebook : 5.7.8
qtconsole        : 4.5.1
...

Running jupyter notebook --version gets only the notebook version. Have not tested on other machines other than my local setup... :roll_eyes:

Petka17 commented 5 years ago

Might it be related to #15

idantene commented 5 years ago

It would definitely lead to the same error @Petka17, in fact - that's why I made this PR. Try pulling this and see if it fixes your issue.

Petka17 commented 5 years ago

Thank you for your reply.

I tried to remove itypescript and then run the following command: npm install -g git+ssh://git@github.com/nearbydelta/itypescript.git#88c73b3ea930666c28d8f2d0e77f64ca58d1f473 but the problem didn't go away.

s0 commented 5 years ago

@Petka17 That won't be sufficient as this PR only changes the .ts files and not .js.

I ran npm run tsc before installing this package and it seemed to fix the problem for me!

@idantene as the js file is checked in, could you also build the typescript file and check in the changes to the javascript file in bin/.

idantene commented 5 years ago

@samlanning of course - my bad for not noticing it earlier. I've included it now (and @Petka17 you may want to try again).

bgnkim commented 5 years ago

Sorry for the late reply. I didn't have much time to check issues and pull requests in this repository. Could you check whether this problem has fixed or not? I just uploaded v0.3.6 based on this pull request.

Petka17 commented 5 years ago

@samlanning of course - my bad for not noticing it earlier. I've included it now (and @Petka17 you may want to try again).

It works! Thank you!

$ npm install -g git+ssh://git@github.com/nearbydelta/itypescript.git#e1997b1307f02f30ad5d09eaae9ba27d56f63f20
$ its --install=local
$ jupyter kernelspec list
Available kernels:
  javascript    /Users/petr/Library/Jupyter/kernels/javascript
  typescript    /Users/petr/Library/Jupyter/kernels/typescript
  java          /usr/local/share/jupyter/kernels/java

I also tried to install directly itypescript package, and it also works.