search

winneon / watch-with-mpv

Open the current web stream with mpv.
https://chrome.google.com/webstore/detail/gbgfakmgjoejbcffelendicfedkegllf
GNU General Public License v2.0
47 stars 2 forks source link

not compatible with chromium #4

Open sl1pkn07 opened 6 years ago

sl1pkn07 commented 6 years ago

I have installed the extension from google play in my chromium-dev from [AUR] (https://aur.archlinux.org/packages/chromium-dev/) and the native watch-with-mpv also from [AUR]

when play videos from youtube and click in the MPV icon:

spectacle nn2088

└───╼  yaourt -Ql watch-with-mpv 
watch-with-mpv /etc/
watch-with-mpv /etc/opt/
watch-with-mpv /etc/opt/chrome/
watch-with-mpv /etc/opt/chrome/native-messaging-hosts/
watch-with-mpv /etc/opt/chrome/native-messaging-hosts/moe.winneon.watchwithmpv.json
watch-with-mpv /usr/
watch-with-mpv /usr/bin/
watch-with-mpv /usr/bin/watch-with-mpv-native-linux

seems the json file is installed path not recognized by chromium

how can fix it?

sl1pkn07 commented 6 years ago

copy the json file to /etc/opt/chromium have the same output (after close chromium enterely)

https://groups.google.com/a/chromium.org/forum/#!topic/chromium-extensions/wSoG7GH6Qrc https://chromium.googlesource.com/chromium/src.git/+/master/chrome/common/chrome_paths.cc#544 https://chromium.googlesource.com/chromium/src.git/+/master/chrome/common/chrome_paths.cc#547

sl1pkn07 commented 6 years ago

OUCH. my fault. is /etc/chromium, not /etc/opt/chromium

now works

sorry for the noise

winneon commented 6 years ago

I'll add support to Chromium in the next version, I was unaware that they use different directories for native hosts. It shouldn't be a difficult fix.