ftpserver.c: Add sanity checks

winnermicro / micropython

MicroPython - a lean and efficient Python implementation for microcontrollers and constrained systems

https://micropython.org

MIT License

9 stars 2 forks source link

Closed robert-hh1 closed 4 years ago

robert-hh1 commented 4 years ago

Line 354. Add "tls_mem_free(sbuf);" beforehand. sbuf is a local variable which is not retained between calls.
Line 171. Add "ls_mem_free(sbuf);" beforehand. buffer is a local variable which is not retained between calls.
function ftp_close_session(). That one seemed wrong, if the session to be closed is not the first one in the list. Besides that, the statements "session->next = NULL;" were obsolete, since the session object was anyhow free'd a few lines later.
add checks after all tls_mem_alloc() calls for success/fail

robert-hh commented 4 years ago

Thanks for merging. But I will update ftpserver later. Last night. I found some more placed to improve. One of them caused corrupted file transfers.

robert-hh1 commented 4 years ago

I'm not sure how to proceed git-wise. You can also re-open that PR. Then I can add the change to this PR. The open changes are:

initialize session->offset to 0. That was not done, and when it had by bad luck values > 0, then downloads either failed or parts of the file were skipped. That happened more rarely than one could assume.
if the name of session->currentdir ended in '/', the the resulting path name contains '//'. That did not cause trouble, so the fix is more cosmetic.
and something REALLY cosmetic: Typos in messages, a user would normally not see.

So only the first change is important.

wdyichen commented 4 years ago

It seems that github does not have a reopen function, please mention a PR again

robert-hh commented 4 years ago

I issued a new PR