search

winnitron / WinnitronLauncher

The official Winnitron launcher! The meat and potatoes of the Winnitron.
winnitron.com
MIT License
34 stars 7 forks source link

Broken Oops state if sync fails #84

Closed aaronklaassen closed 6 years ago

aaronklaassen commented 6 years ago

error reporting broken lol

NullReferenceException: Object reference not set to an instance of an object OopsState.OnStateEnter (UnityEngine.Animator animator, AnimatorStateInfo info, Int32 layerIndex) (at Assets/Scripts/System/StateMachine/States/OopsState.cs:17)

NullReferenceException: Object reference not set to an instance of an object OopsState.OnStateUpdate (UnityEngine.Animator animator, AnimatorStateInfo info, Int32 layerIndex) (at Assets/Scripts/System/StateMachine/States/OopsState.cs:32)

I'm not sure yet if this happens with all Oopses or just this early one. You can replicate it by forcing an error connecting to the Network (e.g., enter a garbage URL in the sync.libraryURL option). The GET fails, tries to Oops, and throws the above exceptions.

mrmwiebe commented 6 years ago

SON OF A

mrmwiebe commented 6 years ago

Haha, well I guess that one is extra fixed now.

mrmwiebe commented 6 years ago

Oops, well I pushed it to the wrong branch anyway. I know how to Git

aaronklaassen commented 6 years ago

@mrmwiebe Hah sorry - I filed the issue, walked away, came back and went "ohhhhhhhhhhh".

I'll roll my commit into a PR that deals with #83 too (that's how I found this).

mrmwiebe commented 6 years ago

No prob!