search

winnow-rs / winnow

Making parsing a breeze
https://docs.rs/winnow
Other
572 stars 44 forks source link

fix: Deprecate signed Uint impls #358

Closed epage closed 1 year ago

epage commented 1 year ago

Inspired by #355

adriandelgado commented 12 months ago

I think this should say /// Deprecated since v0.5.17. On that subject, I personally find it useful to use parse an unsigned integer directly into a i32.

The alternative is to use dec_int which has some machinery to deal with the sign, or to use dec_uint into a u16, and then cast it into a i32. This is just a minor inconvenience.

adriandelgado commented 11 months ago

@epage Friendly ping to update the comment from /// Deprecated since v0.15.17 to /// Deprecated since v0.5.17.