winnow-rs / winnow

Making parsing a breeze
https://docs.rs/winnow
Other
572 stars 44 forks source link

fix(combinator): remove infinite loop check in finite loop #366

Closed vwkd closed 1 year ago

vwkd commented 1 year ago

From #365, this proposes to remove the infinite loop check in the finite loop in separated_n_ added in #362.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 6750570959


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/combinator/multi.rs 0 5 0.0%
<!-- Total: 0 5 0.0% -->
Totals Coverage Status
Change from base Build 6750455444: 0.1%
Covered Lines: 1209
Relevant Lines: 2722

💛 - Coveralls
vwkd commented 1 year ago

Closing in favor of adding the infinite loop check to repeat_n_ in #368 as discussed in https://github.com/winnow-rs/winnow/issues/365#issuecomment-1793243185