search

winnow-rs / winnow

Making parsing a breeze
https://docs.rs/winnow
Other
572 stars 44 forks source link

fix(combinator)!: add missing infinite loop check to repeat #368

Closed vwkd closed 9 months ago

vwkd commented 1 year ago

Add the missing infinite loop check to repeat_n_ to make the error consistent.

As discussed in #365.

epage commented 1 year ago

Thanks for doing this follow up!

As this is a breaking change, I lean towards waiting for enough of these or something more pressing to push us to breaking compatibility. I'm trying to hold off and consolidate on those to see how well we can evolve and manage things without breaking to get an idea of when 1.0 might be appropriate.

epage commented 9 months ago

I merged this as part of #449