Closed epage closed 7 months ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
src/ascii/mod.rs | 0 | 2 | 0.0% | ||
src/parser.rs | 1 | 3 | 33.33% | ||
<!-- | Total: | 1 | 5 | 20.0% | --> |
Totals | |
---|---|
Change from base Build 7818240433: | 0.1% |
Covered Lines: | 1319 |
Relevant Lines: | 3089 |
Attention: 4 lines
in your changes are missing coverage. Please review.
Comparison is base (
3373ba1
) 42.60% compared to head (502a36f
) 42.57%.
Files | Patch % | Lines |
---|---|---|
src/ascii/mod.rs | 0.00% | 2 Missing :warning: |
src/parser.rs | 33.33% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Originally, this was going to be done for performance reasons but when comparing this to the previous commit,
tag(char)
/char
slowed down dramatically in thenext_slice
benchmark.However,
json
benchmark was unchanged. This also (slightly) simplifies traces, is more direct in what it says, and does still speed things up for UTF-8-exclusivechar
s, so going forward with it.Fixes #418 Fixes #427
BREAKING CHANGE:
char
parers now always returnchar
as the output and now requireI: Compare<char>
BREAKING CHANGE:
u8
parers now requireI: Compare<u8>